Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Unified Diff: pylib/gyp/__init__.py

Issue 24803004: Add an option to prune unwanted targets (Closed) Base URL: http://gyp.googlecode.com/svn/trunk
Patch Set: prune based on a set of root targets instead of build_files Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pylib/gyp/common.py » ('j') | test/prune_targets/lib_indirect.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pylib/gyp/__init__.py
diff --git a/pylib/gyp/__init__.py b/pylib/gyp/__init__.py
index 61ce418723ad252cc8b62fc62f4d0943836efef9..0e79de9647873a84ec60d32a78000960b2c2bbec 100755
--- a/pylib/gyp/__init__.py
+++ b/pylib/gyp/__init__.py
@@ -128,7 +128,7 @@ def Load(build_files, format, default_variables={},
# Process the input specific to this generator.
result = gyp.input.Load(build_files, default_variables, includes[:],
depth, generator_input_info, check, circular_check,
- params['parallel'])
+ params['parallel'], params['root_targets'])
return [generator] + result
def NameValueListToDict(name_value_list):
@@ -337,6 +337,10 @@ def gyp_main(args):
parser.add_option('--toplevel-dir', dest='toplevel_dir', action='store',
default=None, metavar='DIR', type='path',
help='directory to use as the root of the source tree')
+ parser.add_option('-T', '--target', dest='root_targets', action='append',
Mark Mentovai 2013/10/01 18:37:06 --target isn’t a descriptive enough long name. If
+ metavar='TARGET',
+ help='Prune out targets that are not deep dependencies '
Mark Mentovai 2013/10/01 18:37:06 Prune is fine, you don’t need to prune out.
+ 'of TARGET')
Mark Mentovai 2013/10/01 18:37:06 Can you bump this over so that the ' lines up with
options, build_files_arg = parser.parse_args(args)
build_files = build_files_arg
@@ -506,7 +510,8 @@ def gyp_main(args):
'build_files_arg': build_files_arg,
'gyp_binary': sys.argv[0],
'home_dot_gyp': home_dot_gyp,
- 'parallel': options.parallel}
+ 'parallel': options.parallel,
+ 'root_targets': options.root_targets}
# Start with the default variables from the command line.
[generator, flat_list, targets, data] = Load(build_files, format,
« no previous file with comments | « no previous file | pylib/gyp/common.py » ('j') | test/prune_targets/lib_indirect.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698