Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2480293011:
Ozone: Improve sandboxing documentation (Closed)
DescriptionOzone: Improve sandboxing documentation
The Linux SUID sandbox is going to be removed [1]. Also, it may not
necessary to disable it to run Ozone builds. Instead of repeating
the command line parameter --disable-setuid-sandbox everywhere, the
documentation is changed to point to the general Sandboxing page.
BUG=None
[1] https://bugs.chromium.org/p/chromium/issues/detail?id=312380
Committed: https://crrev.com/399b51c074a3f38fb3defb6af85c14844684c8da
Cr-Commit-Position: refs/heads/master@{#431226}
Patch Set 1 #
Total comments: 2
Messages
Total messages: 18 (9 generated)
fwang@igalia.com changed reviewers: + tonikitoo@igalia.com
PTAL
I think it is looks good. Please state on the commit message a reference to "The Linux SUID sandbox is going to be removed". https://codereview.chromium.org/2480293011/diff/1/docs/ozone_overview.md File docs/ozone_overview.md (right): https://codereview.chromium.org/2480293011/diff/1/docs/ozone_overview.md#newc... docs/ozone_overview.md:215: [sandboxing](linux_sandboxing.md) or to disable it. "you may need to configure or disable [sandboxing](linux_sandboxing.md)" ? also, for a quick in-place reference, maybe list --disable-setuid-sandbox or --no-sandbox here explicitly in this paragraph?
> Please state on the commit message a reference to "The Linux SUID sandbox is going to be removed". OK, will do that. https://codereview.chromium.org/2480293011/diff/1/docs/ozone_overview.md File docs/ozone_overview.md (right): https://codereview.chromium.org/2480293011/diff/1/docs/ozone_overview.md#newc... docs/ozone_overview.md:215: [sandboxing](linux_sandboxing.md) or to disable it. On 2016/11/09 15:02:34, tonikitoo wrote: > "you may need to configure or disable [sandboxing](linux_sandboxing.md)" ? > > also, for a quick in-place reference, maybe list --disable-setuid-sandbox or > --no-sandbox here explicitly in this paragraph? I'd prefer to not discuss sandboxing at all on this page, as it is likely to change again (for example suid sandboxing will go away). People can find the latest up-to-date doc on the referred page.
Description was changed from ========== Ozone: Improve sandboxing documentation The Linux SUID sandbox is going to be removed. Also, it is not necessary to disable it to run Ozone builds. Instead of repeating the command line parameter --disable-setuid-sandbox everywhere, the documentation is changed to point to the general Linux Sandboxing page. BUG=None ========== to ========== Ozone: Improve sandboxing documentation The Linux SUID sandbox is going to be removed [1]. Also, it may not necessary to disable it to run Ozone builds. Instead of repeating the command line parameter --disable-setuid-sandbox everywhere, the documentation is changed to point to the general Sandboxing page. BUG=None ==========
Description was changed from ========== Ozone: Improve sandboxing documentation The Linux SUID sandbox is going to be removed [1]. Also, it may not necessary to disable it to run Ozone builds. Instead of repeating the command line parameter --disable-setuid-sandbox everywhere, the documentation is changed to point to the general Sandboxing page. BUG=None ========== to ========== Ozone: Improve sandboxing documentation The Linux SUID sandbox is going to be removed [1]. Also, it may not necessary to disable it to run Ozone builds. Instead of repeating the command line parameter --disable-setuid-sandbox everywhere, the documentation is changed to point to the general Sandboxing page. BUG=None [1] https://bugs.chromium.org/p/chromium/issues/detail?id=312380 ==========
lgtm. robert, wdyt?
The CQ bit was checked by fwang@igalia.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by fwang@igalia.com
The CQ bit was checked by fwang@igalia.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Ozone: Improve sandboxing documentation The Linux SUID sandbox is going to be removed [1]. Also, it may not necessary to disable it to run Ozone builds. Instead of repeating the command line parameter --disable-setuid-sandbox everywhere, the documentation is changed to point to the general Sandboxing page. BUG=None [1] https://bugs.chromium.org/p/chromium/issues/detail?id=312380 ========== to ========== Ozone: Improve sandboxing documentation The Linux SUID sandbox is going to be removed [1]. Also, it may not necessary to disable it to run Ozone builds. Instead of repeating the command line parameter --disable-setuid-sandbox everywhere, the documentation is changed to point to the general Sandboxing page. BUG=None [1] https://bugs.chromium.org/p/chromium/issues/detail?id=312380 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Ozone: Improve sandboxing documentation The Linux SUID sandbox is going to be removed [1]. Also, it may not necessary to disable it to run Ozone builds. Instead of repeating the command line parameter --disable-setuid-sandbox everywhere, the documentation is changed to point to the general Sandboxing page. BUG=None [1] https://bugs.chromium.org/p/chromium/issues/detail?id=312380 ========== to ========== Ozone: Improve sandboxing documentation The Linux SUID sandbox is going to be removed [1]. Also, it may not necessary to disable it to run Ozone builds. Instead of repeating the command line parameter --disable-setuid-sandbox everywhere, the documentation is changed to point to the general Sandboxing page. BUG=None [1] https://bugs.chromium.org/p/chromium/issues/detail?id=312380 Committed: https://crrev.com/399b51c074a3f38fb3defb6af85c14844684c8da Cr-Commit-Position: refs/heads/master@{#431226} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/399b51c074a3f38fb3defb6af85c14844684c8da Cr-Commit-Position: refs/heads/master@{#431226}
Message was sent while issue was closed.
rjkroege@chromium.org changed reviewers: + rjkroege@chromium.org
Message was sent while issue was closed.
lgtm. Thanks very much. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
