extensions/browser/api/networking_private/networking_private_service_client.cc - Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/networking_private/networking_private_service_client.cc

Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode. (Closed)

Patch Set: Clean up unnecessary release/cast Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/cache_storage/cache_storage_cache.cc ('K') | « content/shell/browser/layout_test/layout_test_permission_manager.cc ('k') | storage/browser/fileapi/file_system_operation_runner.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/networking_private/networking_private_service_client.cc

diff --git a/extensions/browser/api/networking_private/networking_private_service_client.cc b/extensions/browser/api/networking_private/networking_private_service_client.cc

index da828a8a70d99f2e8aa39ec84f8ae86db39265ed..8b9acf62df1b92ac59c4c08f4786726c81f28997 100644

--- a/extensions/browser/api/networking_private/networking_private_service_client.cc

+++ b/extensions/browser/api/networking_private/networking_private_service_client.cc

@@ -106,7 +106,8 @@ void NetworkingPrivateServiceClient::OnNetworkChanged(

NetworkingPrivateServiceClient::ServiceCallbacks*

NetworkingPrivateServiceClient::AddServiceCallbacks() {

ServiceCallbacks* service_callbacks = new ServiceCallbacks();

- service_callbacks->id = callbacks_map_.Add(service_callbacks);

+ service_callbacks->id =

+ callbacks_map_.Add(std::unique_ptr<ServiceCallbacks>(service_callbacks));

return service_callbacks;

}