Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Unified Diff: content/browser/cache_storage/cache_storage_cache.cc

Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode. (Closed)
Patch Set: Clean up unnecessary release/cast Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/cache_storage/cache_storage_cache.cc
diff --git a/content/browser/cache_storage/cache_storage_cache.cc b/content/browser/cache_storage/cache_storage_cache.cc
index 6ca5786b882581b11095984e4565ee02f7e691fc..52dbd039d935868b0765f55946fc68d8a7444af5 100644
--- a/content/browser/cache_storage/cache_storage_cache.cc
+++ b/content/browser/cache_storage/cache_storage_cache.cc
@@ -1133,7 +1133,8 @@ void CacheStorageCache::PutDidWriteHeaders(
CacheStorageBlobToDiskCache* blob_to_cache =
new CacheStorageBlobToDiskCache();
BlobToDiskCacheIDMap::KeyType blob_to_cache_key =
- active_blob_to_disk_cache_writers_.Add(blob_to_cache);
+ active_blob_to_disk_cache_writers_.Add(
+ std::unique_ptr<CacheStorageBlobToDiskCache>(blob_to_cache));
aelias_OOO_until_Jul13 2016/11/10 06:04:48 base::MakeUnique<CacheStorageBlobToDiskCache>
rlanday 2016/11/10 18:20:01 This is another weird one, blob_to_cache is insert
std::unique_ptr<storage::BlobDataHandle> blob_data_handle =
std::move(put_context->blob_data_handle);

Powered by Google App Engine
This is Rietveld 408576698