Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.h

Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode. (Closed)
Patch Set: Make changes requested by danakj, fix a few more headers Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.h
diff --git a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.h b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.h
index e7501de0fe43d41095f702e8c6add0184c4f6b76..460792300ca1cab65171e5eba6c54afd24bc8b03 100644
--- a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.h
+++ b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.h
@@ -51,10 +51,12 @@ class ServiceWorkerGlobalScopeClientImpl final
static ServiceWorkerGlobalScopeClient* create(WebServiceWorkerContextClient&);
~ServiceWorkerGlobalScopeClientImpl() override;
- void getClient(const WebString&, WebServiceWorkerClientCallbacks*) override;
+ void getClient(const WebString&,
+ std::unique_ptr<WebServiceWorkerClientCallbacks>) override;
void getClients(const WebServiceWorkerClientQueryOptions&,
- WebServiceWorkerClientsCallbacks*) override;
- void openWindow(const WebURL&, WebServiceWorkerClientCallbacks*) override;
+ std::unique_ptr<WebServiceWorkerClientsCallbacks>) override;
+ void openWindow(const WebURL&,
+ std::unique_ptr<WebServiceWorkerClientCallbacks>) override;
void setCachedMetadata(const WebURL&, const char*, size_t) override;
void clearCachedMetadata(const WebURL&) override;
@@ -96,13 +98,14 @@ class ServiceWorkerGlobalScopeClientImpl final
const WebCrossOriginServiceWorkerClient&,
const WebString& message,
std::unique_ptr<WebMessagePortChannelArray>) override;
- void skipWaiting(WebServiceWorkerSkipWaitingCallbacks*) override;
- void claim(WebServiceWorkerClientsClaimCallbacks*) override;
+ void skipWaiting(
+ std::unique_ptr<WebServiceWorkerSkipWaitingCallbacks>) override;
+ void claim(std::unique_ptr<WebServiceWorkerClientsClaimCallbacks>) override;
void focus(const WebString& clientUUID,
- WebServiceWorkerClientCallbacks*) override;
+ std::unique_ptr<WebServiceWorkerClientCallbacks>) override;
void navigate(const WebString& clientUUID,
const WebURL&,
- WebServiceWorkerClientCallbacks*) override;
+ std::unique_ptr<WebServiceWorkerClientCallbacks>) override;
void registerForeignFetchScopes(const WebVector<WebURL>& subScopes,
const WebVector<WebSecurityOrigin>&) override;

Powered by Google App Engine
This is Rietveld 408576698