third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationController.h - Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationController.h

Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode. (Closed)

Patch Set: Make changes requested by danakj, fix a few more headers Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/screen_orientation/ScreenOrientation.cpp ('k') | third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationController.h

diff --git a/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationController.h b/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationController.h

index 7917539e0d46383996ac6a597238a72da8d9c5d7..2fb4e894bad191a6e39d669fd6bcc42a385244a5 100644

--- a/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationController.h

+++ b/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationController.h

@@ -13,6 +13,7 @@

#include "public/platform/modules/screen_orientation/WebLockOrientationCallback.h"

#include "public/platform/modules/screen_orientation/WebScreenOrientationLockType.h"

#include "public/platform/modules/screen_orientation/WebScreenOrientationType.h"

+#include <memory>

namespace blink {

@@ -33,7 +34,8 @@ class MODULES_EXPORT ScreenOrientationController final

void setOrientation(ScreenOrientation*);

void notifyOrientationChanged();

- void lock(WebScreenOrientationLockType, WebLockOrientationCallback*);

+ void lock(WebScreenOrientationLockType,

+ std::unique_ptr<WebLockOrientationCallback>);

void unlock();

static void provideTo(LocalFrame&, WebScreenOrientationClient*);