Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Unified Diff: third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationController.cpp

Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode. (Closed)
Patch Set: Make changes requested by danakj, fix a few more headers Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationController.cpp
diff --git a/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationController.cpp b/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationController.cpp
index dbeed629a02df14a7bef88672134a0d5b8a1d270..af8642e73bfab8f200bc04ef3fd4603fa72b7a1a 100644
--- a/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationController.cpp
+++ b/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationController.cpp
@@ -16,6 +16,8 @@
#include "platform/ScopedOrientationChangeIndicator.h"
#include "public/platform/WebScreenInfo.h"
#include "public/platform/modules/screen_orientation/WebScreenOrientationClient.h"
+#include <memory>
+#include <utility>
namespace blink {
@@ -165,12 +167,13 @@ void ScreenOrientationController::setOrientation(
notifyDispatcher();
}
-void ScreenOrientationController::lock(WebScreenOrientationLockType orientation,
- WebLockOrientationCallback* callback) {
+void ScreenOrientationController::lock(
+ WebScreenOrientationLockType orientation,
+ std::unique_ptr<WebLockOrientationCallback> callback) {
// When detached, the client is no longer valid.
if (!m_client)
return;
- m_client->lockOrientation(orientation, callback);
+ m_client->lockOrientation(orientation, std::move(callback));
}
void ScreenOrientationController::unlock() {

Powered by Google App Engine
This is Rietveld 408576698