storage/browser/fileapi/file_system_operation_runner.h - Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: storage/browser/fileapi/file_system_operation_runner.h

Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode. (Closed)

Patch Set: Make changes requested by danakj, fix a few more headers Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: storage/browser/fileapi/file_system_operation_runner.h

diff --git a/storage/browser/fileapi/file_system_operation_runner.h b/storage/browser/fileapi/file_system_operation_runner.h

index 621a7d9b28e3ab3000f7e6c4ac9078bbb1e37866..a59058a0946a28a3e605f3f977192e8c87301480 100644

--- a/storage/browser/fileapi/file_system_operation_runner.h

+++ b/storage/browser/fileapi/file_system_operation_runner.h

@@ -300,7 +300,7 @@ class STORAGE_EXPORT FileSystemOperationRunner

void PrepareForRead(OperationID id, const FileSystemURL& url);

// These must be called at the beginning and end of any async operations.

- OperationHandle BeginOperation(FileSystemOperation* operation,

+ OperationHandle BeginOperation(std::unique_ptr<FileSystemOperation> operation,

base::WeakPtr<BeginOperationScoper> scope);

void FinishOperation(OperationID id);