content/shell/browser/layout_test/layout_test_permission_manager.cc - Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/layout_test/layout_test_permission_manager.cc

Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode. (Closed)

Patch Set: Make changes requested by danakj, fix a few more headers Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/service_worker/service_worker_context_client.cc ('k') | extensions/browser/api/networking_private/networking_private_service_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/browser/layout_test/layout_test_permission_manager.cc

diff --git a/content/shell/browser/layout_test/layout_test_permission_manager.cc b/content/shell/browser/layout_test/layout_test_permission_manager.cc

index 48030a7a62d63f9f02336cf0bfa3c6caca3f21b8..465aeb42f5a5f741b100f7c64f15adcea3d73100 100644

--- a/content/shell/browser/layout_test/layout_test_permission_manager.cc

+++ b/content/shell/browser/layout_test/layout_test_permission_manager.cc

@@ -5,6 +5,8 @@

#include "content/shell/browser/layout_test/layout_test_permission_manager.h"

#include <list>

+#include <memory>

+#include <utility>

#include "base/bind.h"

#include "base/callback.h"

@@ -147,7 +149,7 @@ int LayoutTestPermissionManager::SubscribePermissionStatusChange(

const base::Callback<void(blink::mojom::PermissionStatus)>& callback) {

DCHECK_CURRENTLY_ON(BrowserThread::UI);

- Subscription* subscription = new Subscription();

+ auto subscription = base::MakeUnique<Subscription>();

subscription->permission =

PermissionDescription(permission, requesting_origin, embedding_origin);

subscription->callback = callback;

@@ -156,7 +158,7 @@ int LayoutTestPermissionManager::SubscribePermissionStatusChange(

subscription->permission.origin,

subscription->permission.embedding_origin);

- return subscriptions_.Add(subscription);

+ return subscriptions_.Add(std::move(subscription));

}

void LayoutTestPermissionManager::UnsubscribePermissionStatusChange(