content/renderer/renderer_blink_platform_impl.h - Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/renderer_blink_platform_impl.h

Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode. (Closed)

Patch Set: Make changes requested by danakj, fix a few more headers Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/renderer_blink_platform_impl.h

diff --git a/content/renderer/renderer_blink_platform_impl.h b/content/renderer/renderer_blink_platform_impl.h

index 15d386c960cdb9bba8cb39bba13f7767e56e1ecb..fb2c5aac52e8ff067ea8b435bc45e83e8ec12840 100644

--- a/content/renderer/renderer_blink_platform_impl.h

+++ b/content/renderer/renderer_blink_platform_impl.h

@@ -242,8 +242,8 @@ class CONTENT_EXPORT RendererBlinkPlatformImpl : public BlinkPlatformImpl {

// Factory that takes a type and return PlatformEventObserverBase that matches

// it.

- static PlatformEventObserverBase* CreatePlatformEventObserverFromType(

- blink::WebPlatformEventType type);

+ static std::unique_ptr<PlatformEventObserverBase>

+ CreatePlatformEventObserverFromType(blink::WebPlatformEventType type);

// Use the data previously set via SetMockDevice...DataForTesting() and send

// them to the registered listener.