Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1274)

Unified Diff: content/renderer/push_messaging/push_messaging_dispatcher.h

Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode. (Closed)
Patch Set: Make changes requested by danakj, fix a few more headers Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/push_messaging/push_messaging_dispatcher.h
diff --git a/content/renderer/push_messaging/push_messaging_dispatcher.h b/content/renderer/push_messaging/push_messaging_dispatcher.h
index cd8c7a349c48d291ef22e05a44ca4a6a9cd300e9..5287c3d9cdc33a572ee299aa0aa5e5c470b8f766 100644
--- a/content/renderer/push_messaging/push_messaging_dispatcher.h
+++ b/content/renderer/push_messaging/push_messaging_dispatcher.h
@@ -6,6 +6,8 @@
#define CONTENT_RENDERER_PUSH_MESSAGING_PUSH_MESSAGING_DISPATCHER_H_
#include <stdint.h>
+
+#include <memory>
#include <string>
#include <vector>
@@ -47,12 +49,12 @@ class PushMessagingDispatcher : public RenderFrameObserver,
void subscribe(
blink::WebServiceWorkerRegistration* service_worker_registration,
const blink::WebPushSubscriptionOptions& options,
- blink::WebPushSubscriptionCallbacks* callbacks) override;
+ std::unique_ptr<blink::WebPushSubscriptionCallbacks> callbacks) override;
void DidGetManifest(
blink::WebServiceWorkerRegistration* service_worker_registration,
const blink::WebPushSubscriptionOptions& options,
- blink::WebPushSubscriptionCallbacks* callbacks,
+ std::unique_ptr<blink::WebPushSubscriptionCallbacks> callbacks,
const GURL& manifest_url,
const Manifest& manifest,
const ManifestDebugInfo&);
@@ -60,7 +62,7 @@ class PushMessagingDispatcher : public RenderFrameObserver,
void DoSubscribe(
blink::WebServiceWorkerRegistration* service_worker_registration,
const PushSubscriptionOptions& options,
- blink::WebPushSubscriptionCallbacks* callbacks);
+ std::unique_ptr<blink::WebPushSubscriptionCallbacks> callbacks);
void OnSubscribeFromDocumentSuccess(int32_t request_id,
const GURL& endpoint,
« no previous file with comments | « content/renderer/presentation/presentation_dispatcher.cc ('k') | content/renderer/push_messaging/push_messaging_dispatcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698