Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2314)

Unified Diff: content/child/service_worker/service_worker_dispatcher.h

Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode. (Closed)
Patch Set: Make changes requested by danakj, fix a few more headers Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/child/quota_dispatcher.cc ('k') | content/child/service_worker/service_worker_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/service_worker/service_worker_dispatcher.h
diff --git a/content/child/service_worker/service_worker_dispatcher.h b/content/child/service_worker/service_worker_dispatcher.h
index a11038a9d92f5c6993a4fe288c9398fdf686008f..61a6c733c734039fe7ed65ba74fe5881992c9a25 100644
--- a/content/child/service_worker/service_worker_dispatcher.h
+++ b/content/child/service_worker/service_worker_dispatcher.h
@@ -86,28 +86,31 @@ class CONTENT_EXPORT ServiceWorkerDispatcher : public WorkerThread::Observer {
int provider_id,
const GURL& pattern,
const GURL& script_url,
- WebServiceWorkerRegistrationCallbacks* callbacks);
+ std::unique_ptr<WebServiceWorkerRegistrationCallbacks> callbacks);
// Corresponds to ServiceWorkerRegistration.update().
- void UpdateServiceWorker(int provider_id,
- int64_t registration_id,
- WebServiceWorkerUpdateCallbacks* callbacks);
+ void UpdateServiceWorker(
+ int provider_id,
+ int64_t registration_id,
+ std::unique_ptr<WebServiceWorkerUpdateCallbacks> callbacks);
// Corresponds to ServiceWorkerRegistration.unregister().
void UnregisterServiceWorker(
int provider_id,
int64_t registration_id,
- WebServiceWorkerUnregistrationCallbacks* callbacks);
+ std::unique_ptr<WebServiceWorkerUnregistrationCallbacks> callbacks);
// Corresponds to navigator.serviceWorker.getRegistration().
- void GetRegistration(int provider_id,
- const GURL& document_url,
- WebServiceWorkerGetRegistrationCallbacks* callbacks);
+ void GetRegistration(
+ int provider_id,
+ const GURL& document_url,
+ std::unique_ptr<WebServiceWorkerGetRegistrationCallbacks> callbacks);
// Corresponds to navigator.serviceWorker.getRegistrations().
void GetRegistrations(
int provider_id,
- WebServiceWorkerGetRegistrationsCallbacks* callbacks);
+ std::unique_ptr<WebServiceWorkerGetRegistrationsCallbacks> callbacks);
void GetRegistrationForReady(
int provider_id,
- WebServiceWorkerGetRegistrationForReadyCallbacks* callbacks);
+ std::unique_ptr<WebServiceWorkerGetRegistrationForReadyCallbacks>
+ callbacks);
// Corresponds to NavigationPreloadManager.enable/disable.
void EnableNavigationPreload(
« no previous file with comments | « content/child/quota_dispatcher.cc ('k') | content/child/service_worker/service_worker_dispatcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698