Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: content/child/push_messaging/push_provider.h

Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode. (Closed)
Patch Set: Make changes requested by danakj, fix a few more headers Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/child/notifications/notification_manager.cc ('k') | content/child/push_messaging/push_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/push_messaging/push_provider.h
diff --git a/content/child/push_messaging/push_provider.h b/content/child/push_messaging/push_provider.h
index bd8e9ca13bcb74c9dc052c203f4a9f06521eaec1..70471ff6424685c1a6c851f36a19cddde17b2bff 100644
--- a/content/child/push_messaging/push_provider.h
+++ b/content/child/push_messaging/push_provider.h
@@ -6,6 +6,8 @@
#define CONTENT_CHILD_PUSH_MESSAGING_PUSH_PROVIDER_H_
#include <stdint.h>
+
+#include <memory>
#include <string>
#include <vector>
@@ -50,17 +52,18 @@ class PushProvider : public blink::WebPushProvider,
void subscribe(
blink::WebServiceWorkerRegistration* service_worker_registration,
const blink::WebPushSubscriptionOptions& options,
- blink::WebPushSubscriptionCallbacks* callbacks) override;
+ std::unique_ptr<blink::WebPushSubscriptionCallbacks> callbacks) override;
void unsubscribe(
blink::WebServiceWorkerRegistration* service_worker_registration,
- blink::WebPushUnsubscribeCallbacks* callbacks) override;
+ std::unique_ptr<blink::WebPushUnsubscribeCallbacks> callbacks) override;
void getSubscription(
blink::WebServiceWorkerRegistration* service_worker_registration,
- blink::WebPushSubscriptionCallbacks* callbacks) override;
+ std::unique_ptr<blink::WebPushSubscriptionCallbacks> callbacks) override;
void getPermissionStatus(
blink::WebServiceWorkerRegistration* service_worker_registration,
const blink::WebPushSubscriptionOptions& options,
- blink::WebPushPermissionStatusCallbacks* callbacks) override;
+ std::unique_ptr<blink::WebPushPermissionStatusCallbacks> callbacks)
+ override;
// Called by the PushDispatcher.
bool OnMessageReceived(const IPC::Message& message);
« no previous file with comments | « content/child/notifications/notification_manager.cc ('k') | content/child/push_messaging/push_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698