Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: content/child/fileapi/file_system_dispatcher.cc

Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode. (Closed)
Patch Set: Make changes requested by danakj, fix a few more headers Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/quota_dispatcher_host.cc ('k') | content/child/notifications/notification_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/fileapi/file_system_dispatcher.cc
diff --git a/content/child/fileapi/file_system_dispatcher.cc b/content/child/fileapi/file_system_dispatcher.cc
index 1fdf49527306648e2070be452c1b961c78af0f5f..e2467709850c74813b905a917adf80f0ce7469ce 100644
--- a/content/child/fileapi/file_system_dispatcher.cc
+++ b/content/child/fileapi/file_system_dispatcher.cc
@@ -4,6 +4,8 @@
#include "content/child/fileapi/file_system_dispatcher.h"
+#include <memory>
+
#include "base/callback.h"
#include "base/files/file_util.h"
#include "base/macros.h"
@@ -25,50 +27,57 @@ class FileSystemDispatcher::CallbackDispatcher {
typedef FileSystemDispatcher::WriteCallback WriteCallback;
typedef FileSystemDispatcher::OpenFileCallback OpenFileCallback;
- static CallbackDispatcher* Create(const StatusCallback& callback) {
- CallbackDispatcher* dispatcher = new CallbackDispatcher;
+ static std::unique_ptr<CallbackDispatcher> Create(
+ const StatusCallback& callback) {
+ auto dispatcher = base::WrapUnique(new CallbackDispatcher);
dispatcher->status_callback_ = callback;
dispatcher->error_callback_ = callback;
return dispatcher;
}
- static CallbackDispatcher* Create(const MetadataCallback& callback,
- const StatusCallback& error_callback) {
- CallbackDispatcher* dispatcher = new CallbackDispatcher;
+ static std::unique_ptr<CallbackDispatcher> Create(
+ const MetadataCallback& callback,
+ const StatusCallback& error_callback) {
+ auto dispatcher = base::WrapUnique(new CallbackDispatcher);
dispatcher->metadata_callback_ = callback;
dispatcher->error_callback_ = error_callback;
return dispatcher;
}
- static CallbackDispatcher* Create(const CreateSnapshotFileCallback& callback,
- const StatusCallback& error_callback) {
- CallbackDispatcher* dispatcher = new CallbackDispatcher;
+ static std::unique_ptr<CallbackDispatcher> Create(
+ const CreateSnapshotFileCallback& callback,
+ const StatusCallback& error_callback) {
+ auto dispatcher = base::WrapUnique(new CallbackDispatcher);
dispatcher->snapshot_callback_ = callback;
dispatcher->error_callback_ = error_callback;
return dispatcher;
}
- static CallbackDispatcher* Create(const ReadDirectoryCallback& callback,
- const StatusCallback& error_callback) {
- CallbackDispatcher* dispatcher = new CallbackDispatcher;
+ static std::unique_ptr<CallbackDispatcher> Create(
+ const ReadDirectoryCallback& callback,
+ const StatusCallback& error_callback) {
+ auto dispatcher = base::WrapUnique(new CallbackDispatcher);
dispatcher->directory_callback_ = callback;
dispatcher->error_callback_ = error_callback;
return dispatcher;
}
- static CallbackDispatcher* Create(const OpenFileSystemCallback& callback,
- const StatusCallback& error_callback) {
- CallbackDispatcher* dispatcher = new CallbackDispatcher;
+ static std::unique_ptr<CallbackDispatcher> Create(
+ const OpenFileSystemCallback& callback,
+ const StatusCallback& error_callback) {
+ auto dispatcher = base::WrapUnique(new CallbackDispatcher);
dispatcher->filesystem_callback_ = callback;
dispatcher->error_callback_ = error_callback;
return dispatcher;
}
- static CallbackDispatcher* Create(const ResolveURLCallback& callback,
- const StatusCallback& error_callback) {
- CallbackDispatcher* dispatcher = new CallbackDispatcher;
+ static std::unique_ptr<CallbackDispatcher> Create(
+ const ResolveURLCallback& callback,
+ const StatusCallback& error_callback) {
+ auto dispatcher = base::WrapUnique(new CallbackDispatcher);
dispatcher->resolve_callback_ = callback;
dispatcher->error_callback_ = error_callback;
return dispatcher;
}
- static CallbackDispatcher* Create(const WriteCallback& callback,
- const StatusCallback& error_callback) {
- CallbackDispatcher* dispatcher = new CallbackDispatcher;
+ static std::unique_ptr<CallbackDispatcher> Create(
+ const WriteCallback& callback,
+ const StatusCallback& error_callback) {
+ auto dispatcher = base::WrapUnique(new CallbackDispatcher);
dispatcher->write_callback_ = callback;
dispatcher->error_callback_ = error_callback;
return dispatcher;
« no previous file with comments | « content/browser/quota_dispatcher_host.cc ('k') | content/child/notifications/notification_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698