Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Unified Diff: content/browser/permissions/permission_service_impl.cc

Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode. (Closed)
Patch Set: Make changes requested by danakj, fix a few more headers Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/manifest/manifest_manager_host.cc ('k') | content/browser/quota_dispatcher_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/permissions/permission_service_impl.cc
diff --git a/content/browser/permissions/permission_service_impl.cc b/content/browser/permissions/permission_service_impl.cc
index ccb70ff5db558f1029b1405c7b9ba84465d5f09b..44851b7a597304e0db480de47bd3c4fd66c41a5a 100644
--- a/content/browser/permissions/permission_service_impl.cc
+++ b/content/browser/permissions/permission_service_impl.cc
@@ -5,9 +5,12 @@
#include "content/browser/permissions/permission_service_impl.h"
#include <stddef.h>
+
+#include <memory>
#include <utility>
#include "base/bind.h"
+#include "base/memory/ptr_util.h"
#include "content/public/browser/browser_context.h"
#include "content/public/browser/permission_manager.h"
#include "content/public/browser/permission_type.h"
@@ -130,8 +133,9 @@ void PermissionServiceImpl::RequestPermission(
return;
}
- int pending_request_id = pending_requests_.Add(new PendingRequest(
- base::Bind(&PermissionRequestResponseCallbackWrapper, callback), 1));
+ int pending_request_id =
+ pending_requests_.Add(base::MakeUnique<PendingRequest>(
+ base::Bind(&PermissionRequestResponseCallbackWrapper, callback), 1));
int id = browser_context->GetPermissionManager()->RequestPermission(
PermissionDescriptorToPermissionType(permission),
context_->render_frame_host(), origin.GetURL(), user_gesture,
@@ -182,7 +186,7 @@ void PermissionServiceImpl::RequestPermissions(
types[i] = PermissionDescriptorToPermissionType(permissions[i]);
int pending_request_id = pending_requests_.Add(
- new PendingRequest(callback, permissions.size()));
+ base::MakeUnique<PendingRequest>(callback, permissions.size()));
int id = browser_context->GetPermissionManager()->RequestPermissions(
types, context_->render_frame_host(), origin.GetURL(), user_gesture,
base::Bind(&PermissionServiceImpl::OnRequestPermissionsResponse,
@@ -287,13 +291,15 @@ void PermissionServiceImpl::GetNextPermissionChange(
// We need to pass the id of PendingSubscription in pending_subscriptions_
// to the callback but SubscribePermissionStatusChange() will also return an
// id which is different.
- PendingSubscription* subscription =
- new PendingSubscription(permission_type, origin, callback);
- int pending_subscription_id = pending_subscriptions_.Add(subscription);
+ auto subscription =
+ base::MakeUnique<PendingSubscription>(permission_type, origin, callback);
+ PendingSubscription* subscription_raw = subscription.get();
+ int pending_subscription_id =
+ pending_subscriptions_.Add(std::move(subscription));
GURL requesting_origin(origin.Serialize());
GURL embedding_origin = context_->GetEmbeddingOrigin();
- subscription->id =
+ subscription_raw->id =
browser_context->GetPermissionManager()->SubscribePermissionStatusChange(
permission_type, requesting_origin,
// If the embedding_origin is empty, we,ll use the |origin| instead.
« no previous file with comments | « content/browser/manifest/manifest_manager_host.cc ('k') | content/browser/quota_dispatcher_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698