chrome/browser/ui/tab_contents/core_tab_helper.cc - Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/tab_contents/core_tab_helper.cc

Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode. (Closed)

Patch Set: Make changes requested by danakj, fix a few more headers Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/tab_contents/core_tab_helper.cc

diff --git a/chrome/browser/ui/tab_contents/core_tab_helper.cc b/chrome/browser/ui/tab_contents/core_tab_helper.cc

index 292ba98f3f90c39b76234c365b6349f943947aee..aba3a32f836f1643230587127dc022cfa0436c1d 100644

--- a/chrome/browser/ui/tab_contents/core_tab_helper.cc

+++ b/chrome/browser/ui/tab_contents/core_tab_helper.cc

@@ -122,7 +122,7 @@ void CoreTabHelper::RequestThumbnailForContextNode(

gfx::Size maximum_size,

const ContextNodeThumbnailCallback& callback) {

int callback_id = thumbnail_callbacks_.Add(

- new ContextNodeThumbnailCallback(callback));

+ base::MakeUnique<ContextNodeThumbnailCallback>(callback));

render_frame_host->Send(

new ChromeViewMsg_RequestThumbnailForContextNode(