Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4520)

Unified Diff: chrome/browser/media/cast_transport_host_filter.cc

Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode. (Closed)
Patch Set: Make changes requested by danakj, fix a few more headers Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/cast_transport_host_filter.cc
diff --git a/chrome/browser/media/cast_transport_host_filter.cc b/chrome/browser/media/cast_transport_host_filter.cc
index be9f8b746e10f97734e5cf5187db3f55f9b704b2..89feefdbd4ab4b1c2749f602e0956623a2a488c8 100644
--- a/chrome/browser/media/cast_transport_host_filter.cc
+++ b/chrome/browser/media/cast_transport_host_filter.cc
@@ -4,6 +4,8 @@
#include "chrome/browser/media/cast_transport_host_filter.h"
+#include <utility>
+
#include "base/memory/ptr_util.h"
#include "base/threading/thread_task_runner_handle.h"
#include "chrome/browser/browser_process.h"
@@ -176,7 +178,7 @@ void CastTransportHostFilter::OnNew(int32_t channel_id,
base::MakeUnique<TransportClient>(channel_id, this),
std::move(udp_transport), base::ThreadTaskRunnerHandle::Get());
transport->SetOptions(options);
- id_map_.AddWithID(transport.release(), channel_id);
+ id_map_.AddWithID(std::move(transport), channel_id);
}
void CastTransportHostFilter::OnDelete(int32_t channel_id) {
@@ -215,7 +217,7 @@ void CastTransportHostFilter::OnInitializeStream(
config.rtp_payload_type == media::cast::RtpPayloadType::REMOTE_VIDEO) {
// Create CastRemotingSender for this RTP stream.
remoting_sender_map_.AddWithID(
- new CastRemotingSender(
+ base::MakeUnique<CastRemotingSender>(
transport, config, kSendEventsInterval,
base::Bind(&CastTransportHostFilter::OnCastRemotingSenderEvents,
weak_factory_.GetWeakPtr(), channel_id)),
« no previous file with comments | « chrome/browser/media/android/router/media_router_android.cc ('k') | chrome/browser/metrics/subprocess_metrics_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698