chrome/browser/android/compositor/layer_title_cache.cc - Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/compositor/layer_title_cache.cc

Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode. (Closed)

Patch Set: Make changes requested by danakj, fix a few more headers Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/compositor/layer_title_cache.cc

diff --git a/chrome/browser/android/compositor/layer_title_cache.cc b/chrome/browser/android/compositor/layer_title_cache.cc

index b2162acb2fa23d46867d11b2a0256a62f730e2df..b19fd95bb044afec9a454bfc42b45bf9eb56f995 100644

--- a/chrome/browser/android/compositor/layer_title_cache.cc

+++ b/chrome/browser/android/compositor/layer_title_cache.cc

@@ -8,6 +8,7 @@

#include <memory>

+#include "base/memory/ptr_util.h"

#include "cc/layers/layer.h"

#include "cc/layers/ui_resource_layer.h"

#include "chrome/browser/android/compositor/decoration_title.h"

@@ -68,7 +69,7 @@ void LayerTitleCache::UpdateLayer(JNIEnv* env,

}

} else {

layer_cache_.AddWithID(

- new DecorationTitle(

+ base::MakeUnique<DecorationTitle>(

resource_manager_, title_resource_id, favicon_resource_id,

spinner_resource_id_, spinner_incognito_resource_id_, fade_width_,

favicon_start_padding_, favicon_end_padding_, is_incognito, is_rtl),

« no previous file with comments | « base/id_map_unittest.cc ('k') | chrome/browser/android/service_tab_launcher.cc » ('j') | no next file with comments »