Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode.

content/renderer/screen_orientation/screen_orientation_dispatcher.cc

Index: content/renderer/screen_orientation/screen_orientation_dispatcher.cc
diff --git a/content/renderer/screen_orientation/screen_orientation_dispatcher.cc b/content/renderer/screen_orientation/screen_orientation_dispatcher.cc
index 2b6a41feba071862301c53a5cd0af059a22ca6fa..71f27748bc57ba49852f6d641fbd37e128b2c8f4 100644
--- a/content/renderer/screen_orientation/screen_orientation_dispatcher.cc
+++ b/content/renderer/screen_orientation/screen_orientation_dispatcher.cc
@@ -4,6 +4,8 @@
 
 #include "content/renderer/screen_orientation/screen_orientation_dispatcher.h"
 
+#include <memory>

[danakj, 2016/11/30 00:34:01]

this file wants utility for move() rather than memory. the unique_ptr is coming
from the header so it should already be there.

[rlanday, 2016/11/30 15:52:01]

Oops...looks like git cl lint's flagging a couple other files for this as well
(e.g. the .h file for this .cc file), I'll add the header on those too

I assume I don't need this #include both here and in the .h?

[danakj, 2016/11/30 19:25:06]

Ya we don't reeally have include-what-you-use tho some sorta warnings I think
exist for a few STL types.
Right, if it's in the .h u can skip it in the .cc

+
 #include "content/public/common/associated_interface_provider.h"
 #include "content/public/renderer/render_frame.h"
 
@@ -65,10 +67,10 @@ void ScreenOrientationDispatcher::CancelPendingLocks() {
 
 void ScreenOrientationDispatcher::lockOrientation(
     blink::WebScreenOrientationLockType orientation,
-    blink::WebLockOrientationCallback* callback) {
+    std::unique_ptr<blink::WebLockOrientationCallback> callback) {
   CancelPendingLocks();
 
-  int request_id = pending_callbacks_.Add(callback);
+  int request_id = pending_callbacks_.Add(std::move(callback));
   EnsureScreenOrientationService();
   screen_orientation_->LockOrientation(
       orientation,