content/child/notifications/notification_manager.h - Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/notifications/notification_manager.h

Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode. (Closed)

Patch Set: Rebase Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/child/notifications/notification_manager.h

diff --git a/content/child/notifications/notification_manager.h b/content/child/notifications/notification_manager.h

index 32a5e4dd3f0d1fd2617e0c31035d538946d4fd17..738a9918c0f7dacf0e18b39b300015c0abb60df2 100644

--- a/content/child/notifications/notification_manager.h

+++ b/content/child/notifications/notification_manager.h

@@ -55,7 +55,7 @@ class NotificationManager : public blink::WebNotificationManager,

void getNotifications(

const blink::WebString& filter_tag,

blink::WebServiceWorkerRegistration* service_worker_registration,

- blink::WebNotificationGetCallbacks* callbacks) override;

+ std::unique_ptr<blink::WebNotificationGetCallbacks> callbacks) override;

void close(blink::WebNotificationDelegate* delegate) override;

void closePersistent(const blink::WebSecurityOrigin& origin,

const blink::WebString& tag,