Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(807)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/drive/job_scheduler.cc

Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode. (Closed)
Patch Set: Rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/permissions/permission_manager.cc ('K') | « chrome/browser/ui/tab_contents/core_tab_helper.cc ('k') | components/gcm_driver/instance_id/instance_id_android.cc » ('j') | content/browser/cache_storage/cache_storage_cache.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/drive/job_scheduler.cc
diff --git a/components/drive/job_scheduler.cc b/components/drive/job_scheduler.cc
index a6568d9aa934ce348aaeeae7842a4839eb11e9a4..9b7c37435f25b3b7162e330f5684469dc5214a73 100644
--- a/components/drive/job_scheduler.cc
+++ b/components/drive/job_scheduler.cc
@@ -721,9 +721,11 @@ void JobScheduler::AddPermission(
}
JobScheduler::JobEntry* JobScheduler::CreateNewJob(JobType type) {
- JobEntry* job = new JobEntry(type);
- job->job_info.job_id = job_map_.Add(job); // Takes the ownership of |job|.
- return job;
+ std::unique_ptr<JobEntry> job = base::MakeUnique<JobEntry>(type);
danakj 2016/11/30 00:34:00 can use auto
+ JobEntry* job_raw = job.get();
+ int32_t job_key = job_map_.Add(std::move(job));
+ job_raw->job_info.job_id = job_key;
+ return job_raw;
}
void JobScheduler::StartJob(JobEntry* job) {
« chrome/browser/permissions/permission_manager.cc ('K') | « chrome/browser/ui/tab_contents/core_tab_helper.cc ('k') | components/gcm_driver/instance_id/instance_id_android.cc » ('j') | content/browser/cache_storage/cache_storage_cache.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698