Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Unified Diff: storage/browser/fileapi/file_system_operation_runner.cc

Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode. (Closed)
Patch Set: Fix typo breaking a bunch of trybot builds, oops Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: storage/browser/fileapi/file_system_operation_runner.cc
diff --git a/storage/browser/fileapi/file_system_operation_runner.cc b/storage/browser/fileapi/file_system_operation_runner.cc
index cc6bd3838ffc385ecb19d2ba5b12a405d1cdef37..99c2a79fbd24b7140f9ce8ca83d36755dfeaf3e6 100644
--- a/storage/browser/fileapi/file_system_operation_runner.cc
+++ b/storage/browser/fileapi/file_system_operation_runner.cc
@@ -658,7 +658,8 @@ FileSystemOperationRunner::BeginOperation(
FileSystemOperation* operation,
danakj 2016/11/18 00:15:34 can be unique_ptr?
base::WeakPtr<BeginOperationScoper> scope) {
OperationHandle handle;
- handle.id = operations_.Add(operation);
+ handle.id = operations_.Add(
+ std::unique_ptr<FileSystemOperation>(operation));
handle.scope = scope;
return handle;
}

Powered by Google App Engine
This is Rietveld 408576698