Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: content/shell/browser/layout_test/layout_test_permission_manager.cc

Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode. (Closed)
Patch Set: Fix typo breaking a bunch of trybot builds, oops Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/shell/browser/layout_test/layout_test_permission_manager.cc
diff --git a/content/shell/browser/layout_test/layout_test_permission_manager.cc b/content/shell/browser/layout_test/layout_test_permission_manager.cc
index 48030a7a62d63f9f02336cf0bfa3c6caca3f21b8..35dd011fb2eb32d5831e85d15aef27b831f9457a 100644
--- a/content/shell/browser/layout_test/layout_test_permission_manager.cc
+++ b/content/shell/browser/layout_test/layout_test_permission_manager.cc
@@ -5,6 +5,7 @@
#include "content/shell/browser/layout_test/layout_test_permission_manager.h"
#include <list>
+#include <memory>
#include "base/bind.h"
#include "base/callback.h"
@@ -147,7 +148,7 @@ int LayoutTestPermissionManager::SubscribePermissionStatusChange(
const base::Callback<void(blink::mojom::PermissionStatus)>& callback) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
- Subscription* subscription = new Subscription();
+ std::unique_ptr<Subscription> subscription = base::MakeUnique<Subscription>();
danakj 2016/11/18 00:15:34 "auto subscription" .. if u want
subscription->permission =
PermissionDescription(permission, requesting_origin, embedding_origin);
subscription->callback = callback;
@@ -156,7 +157,7 @@ int LayoutTestPermissionManager::SubscribePermissionStatusChange(
subscription->permission.origin,
subscription->permission.embedding_origin);
- return subscriptions_.Add(subscription);
+ return subscriptions_.Add(std::move(subscription));
}
void LayoutTestPermissionManager::UnsubscribePermissionStatusChange(

Powered by Google App Engine
This is Rietveld 408576698