Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: content/child/indexed_db/indexed_db_dispatcher.h

Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode. (Closed)
Patch Set: Fix typo breaking a bunch of trybot builds, oops Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/indexed_db/indexed_db_dispatcher.h
diff --git a/content/child/indexed_db/indexed_db_dispatcher.h b/content/child/indexed_db/indexed_db_dispatcher.h
index 3d75d37bc6dc1ba54beb815020c0774b9306c01e..c5ae7d0c925629cd0ac28e6ecf2612e54781fb24 100644
--- a/content/child/indexed_db/indexed_db_dispatcher.h
+++ b/content/child/indexed_db/indexed_db_dispatcher.h
@@ -131,9 +131,9 @@ class CONTENT_EXPORT IndexedDBDispatcher : public WorkerThread::Observer {
template <typename T>
void init_params(T* params, blink::WebIDBCallbacks* callbacks_ptr) {
danakj 2016/11/18 00:15:33 could this be a unique_ptr?
rlanday 2016/11/18 20:40:41 It's unclear to me that this function is used anyw
- std::unique_ptr<blink::WebIDBCallbacks> callbacks(callbacks_ptr);
params->ipc_thread_id = CurrentWorkerId();
- params->ipc_callbacks_id = pending_callbacks_.Add(callbacks.release());
+ params->ipc_callbacks_id = pending_callbacks_.Add(
+ std::unique_ptr<blink::WebIDBCallbacks>(callbacks_ptr));
}
// IDBCallback message handlers.

Powered by Google App Engine
This is Rietveld 408576698