content/browser/indexed_db/indexed_db_dispatcher_host.h - Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/indexed_db/indexed_db_dispatcher_host.h

Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode. (Closed)

Patch Set: Fix typo breaking a bunch of trybot builds, oops Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/indexed_db/indexed_db_dispatcher_host.h

diff --git a/content/browser/indexed_db/indexed_db_dispatcher_host.h b/content/browser/indexed_db/indexed_db_dispatcher_host.h

index e5d7b8d983a2ce09be18c0a14a2a83ceb5e43534..7de7042eb54172dfd8ce7010b55b5b63e8abed0b 100644

--- a/content/browser/indexed_db/indexed_db_dispatcher_host.h

+++ b/content/browser/indexed_db/indexed_db_dispatcher_host.h

@@ -126,7 +126,7 @@ class IndexedDBDispatcherHost

~RefIDMap() {}

KeyType Add(RefCountedType* data) {

- return map_.Add(new scoped_refptr<RefCountedType>(data));

+ return map_.Add(base::MakeUnique<scoped_refptr<RefCountedType>>(data));

}

RefCountedType* Lookup(KeyType id) {