Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1270)

Unified Diff: components/drive/job_scheduler.cc

Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode. (Closed)
Patch Set: Fix typo breaking a bunch of trybot builds, oops Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/drive/job_scheduler.cc
diff --git a/components/drive/job_scheduler.cc b/components/drive/job_scheduler.cc
index a6568d9aa934ce348aaeeae7842a4839eb11e9a4..a7012f668ec8d5840e3aaeca9eb31d0127553053 100644
--- a/components/drive/job_scheduler.cc
+++ b/components/drive/job_scheduler.cc
@@ -721,8 +721,10 @@ void JobScheduler::AddPermission(
}
JobScheduler::JobEntry* JobScheduler::CreateNewJob(JobType type) {
- JobEntry* job = new JobEntry(type);
- job->job_info.job_id = job_map_.Add(job); // Takes the ownership of |job|.
+ int32_t job_key = job_map_.Add(
+ base::MakeUnique<JobEntry>(type));
+ JobEntry* job = job_map_.Lookup(job_key);
danakj 2016/11/18 00:15:32 You don't need to do Lookup, you can just get a po
+ job->job_info.job_id = job_key;
return job;
}

Powered by Google App Engine
This is Rietveld 408576698