content/browser/manifest/manifest_manager_host.cc - Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/manifest/manifest_manager_host.cc

Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/manifest/manifest_manager_host.cc

diff --git a/content/browser/manifest/manifest_manager_host.cc b/content/browser/manifest/manifest_manager_host.cc

index 27e68f6003d4335201f21fe48ed4efe6898da22e..22a4b7f7dec410a0464d7d539a520e13306127a2 100644

--- a/content/browser/manifest/manifest_manager_host.cc

+++ b/content/browser/manifest/manifest_manager_host.cc

@@ -66,7 +66,8 @@ void ManifestManagerHost::GetManifest(RenderFrameHost* render_frame_host,

pending_get_callbacks_[render_frame_host] = base::WrapUnique(callbacks);

}

- int request_id = callbacks->Add(new GetManifestCallback(callback));

+ int request_id = callbacks->Add(

+ base::MakeUnique<GetManifestCallback>(callback));

render_frame_host->Send(new ManifestManagerMsg_RequestManifest(

render_frame_host->GetRoutingID(), request_id));