content/browser/cache_storage/cache_storage_cache.cc - Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/cache_storage/cache_storage_cache.cc

Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/cache_storage/cache_storage_cache.cc

diff --git a/content/browser/cache_storage/cache_storage_cache.cc b/content/browser/cache_storage/cache_storage_cache.cc

index 6ca5786b882581b11095984e4565ee02f7e691fc..52dbd039d935868b0765f55946fc68d8a7444af5 100644

--- a/content/browser/cache_storage/cache_storage_cache.cc

+++ b/content/browser/cache_storage/cache_storage_cache.cc

@@ -1133,7 +1133,8 @@ void CacheStorageCache::PutDidWriteHeaders(

CacheStorageBlobToDiskCache* blob_to_cache =

new CacheStorageBlobToDiskCache();

BlobToDiskCacheIDMap::KeyType blob_to_cache_key =

- active_blob_to_disk_cache_writers_.Add(blob_to_cache);

+ active_blob_to_disk_cache_writers_.Add(

+ std::unique_ptr<CacheStorageBlobToDiskCache>(blob_to_cache));

std::unique_ptr<storage::BlobDataHandle> blob_data_handle =

std::move(put_context->blob_data_handle);