Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode.

third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/notifications/ServiceWorkerRegistrationNotifications.h"
 
 #include "bindings/core/v8/CallbackPromiseAdapter.h"
 #include "bindings/core/v8/ExceptionState.h"
 #include "bindings/core/v8/ScriptPromiseResolver.h"
 #include "core/dom/ExecutionContext.h"
 #include "modules/notifications/GetNotificationOptions.h"
 #include "modules/notifications/Notification.h"
 #include "modules/notifications/NotificationData.h"
 #include "modules/notifications/NotificationManager.h"
 #include "modules/notifications/NotificationOptions.h"
 #include "modules/notifications/NotificationResourcesLoader.h"
 #include "modules/serviceworkers/ServiceWorkerRegistration.h"
 #include "platform/Histogram.h"
 #include "platform/heap/Handle.h"
 #include "public/platform/Platform.h"
 #include "public/platform/WebSecurityOrigin.h"
 #include "public/platform/modules/notifications/WebNotificationData.h"
 #include "wtf/Assertions.h"
 #include "wtf/PtrUtil.h"
 #include "wtf/RefPtr.h"
 #include <memory>
+#include <utility>
 
 namespace blink {
 namespace {
 
 // Allows using a CallbackPromiseAdapter with a WebVector to resolve the
 // getNotifications() promise with a HeapVector owning Notifications.
 class NotificationArray {
  public:
   using WebType = const WebVector<WebPersistentNotificationInfo>&;
 
@@ skipping 76 matching lines @@
   return promise;
 }
 
 ScriptPromise ServiceWorkerRegistrationNotifications::getNotifications(
     ScriptState* scriptState,
     ServiceWorkerRegistration& registration,
     const GetNotificationOptions& options) {
   ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);
   ScriptPromise promise = resolver->promise();
 
-  WebNotificationGetCallbacks* callbacks =
-      new CallbackPromiseAdapter<NotificationArray, void>(resolver);
+  std::unique_ptr<WebNotificationGetCallbacks> callbacks =

[danakj, 2016/11/30 00:34:01]

can auto

+      WTF::makeUnique<CallbackPromiseAdapter<NotificationArray, void>>(
+          resolver);
 
   WebNotificationManager* notificationManager =
       Platform::current()->notificationManager();
   DCHECK(notificationManager);
 
   notificationManager->getNotifications(
-      options.tag(), registration.webRegistration(), callbacks);
+      options.tag(), registration.webRegistration(), std::move(callbacks));
   return promise;
 }
 
 void ServiceWorkerRegistrationNotifications::contextDestroyed() {
   for (auto loader : m_loaders)
     loader->stop();
 }
 
 DEFINE_TRACE(ServiceWorkerRegistrationNotifications) {
   visitor->trace(m_registration);
@@ skipping 45 matching lines @@
       Platform::current()->notificationManager();
   DCHECK(notificationManager);
 
   notificationManager->showPersistent(
       WebSecurityOrigin(origin.get()), data, loader->getResources(),
       m_registration->webRegistration(), callbacks.release());
   m_loaders.remove(loader);
 }
 
 }  // namespace blink