Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: extensions/browser/api/networking_private/networking_private_service_client.cc

Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode. (Closed)
Patch Set: Fix typo breaking a bunch of trybot builds, oops Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/browser/api/networking_private/networking_private_service_c lient.h" 5 #include "extensions/browser/api/networking_private/networking_private_service_c lient.h"
6 6
7 #include "base/base64.h" 7 #include "base/base64.h"
8 #include "base/bind.h" 8 #include "base/bind.h"
9 #include "base/sequenced_task_runner.h" 9 #include "base/sequenced_task_runner.h"
10 #include "base/threading/thread_task_runner_handle.h" 10 #include "base/threading/thread_task_runner_handle.h"
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
99 void NetworkingPrivateServiceClient::OnNetworkChanged( 99 void NetworkingPrivateServiceClient::OnNetworkChanged(
100 net::NetworkChangeNotifier::ConnectionType type) { 100 net::NetworkChangeNotifier::ConnectionType type) {
101 task_runner_->PostTask(FROM_HERE, 101 task_runner_->PostTask(FROM_HERE,
102 base::Bind(&WiFiService::RequestConnectedNetworkUpdate, 102 base::Bind(&WiFiService::RequestConnectedNetworkUpdate,
103 base::Unretained(wifi_service_.get()))); 103 base::Unretained(wifi_service_.get())));
104 } 104 }
105 105
106 NetworkingPrivateServiceClient::ServiceCallbacks* 106 NetworkingPrivateServiceClient::ServiceCallbacks*
107 NetworkingPrivateServiceClient::AddServiceCallbacks() { 107 NetworkingPrivateServiceClient::AddServiceCallbacks() {
108 ServiceCallbacks* service_callbacks = new ServiceCallbacks(); 108 ServiceCallbacks* service_callbacks = new ServiceCallbacks();
109 service_callbacks->id = callbacks_map_.Add(service_callbacks); 109 service_callbacks->id =
110 callbacks_map_.Add(std::unique_ptr<ServiceCallbacks>(service_callbacks));
danakj 2016/11/18 00:15:34 base::WrapUnique
110 return service_callbacks; 111 return service_callbacks;
111 } 112 }
112 113
113 void NetworkingPrivateServiceClient::RemoveServiceCallbacks( 114 void NetworkingPrivateServiceClient::RemoveServiceCallbacks(
114 ServiceCallbacksID callback_id) { 115 ServiceCallbacksID callback_id) {
115 callbacks_map_.Remove(callback_id); 116 callbacks_map_.Remove(callback_id);
116 } 117 }
117 118
118 // NetworkingPrivateServiceClient implementation 119 // NetworkingPrivateServiceClient implementation
119 120
(...skipping 344 matching lines...) Expand 10 before | Expand all | Expand 10 after
464 } 465 }
465 466
466 void NetworkingPrivateServiceClient::OnNetworkListChangedEventOnUIThread( 467 void NetworkingPrivateServiceClient::OnNetworkListChangedEventOnUIThread(
467 const std::vector<std::string>& network_guids) { 468 const std::vector<std::string>& network_guids) {
468 DCHECK_CURRENTLY_ON(BrowserThread::UI); 469 DCHECK_CURRENTLY_ON(BrowserThread::UI);
469 for (auto& observer : network_events_observers_) 470 for (auto& observer : network_events_observers_)
470 observer.OnNetworkListChangedEvent(network_guids); 471 observer.OnNetworkListChangedEvent(network_guids);
471 } 472 }
472 473
473 } // namespace extensions 474 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698