Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Side by Side Diff: content/renderer/service_worker/embedded_worker_dispatcher.cc

Issue 2480293004: Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode. (Closed)
Patch Set: Fix typo breaking a bunch of trybot builds, oops Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/service_worker/embedded_worker_dispatcher.h" 5 #include "content/renderer/service_worker/embedded_worker_dispatcher.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/metrics/histogram_macros.h" 9 #include "base/metrics/histogram_macros.h"
10 #include "base/strings/string16.h" 10 #include "base/strings/string16.h"
(...skipping 139 matching lines...) Expand 10 before | Expand all | Expand 10 after
150 ? blink::WebEmbeddedWorkerStartData::PauseAfterDownload 150 ? blink::WebEmbeddedWorkerStartData::PauseAfterDownload
151 : blink::WebEmbeddedWorkerStartData::DontPauseAfterDownload; 151 : blink::WebEmbeddedWorkerStartData::DontPauseAfterDownload;
152 152
153 wrapper->worker()->startWorkerContext(start_data); 153 wrapper->worker()->startWorkerContext(start_data);
154 return wrapper; 154 return wrapper;
155 } 155 }
156 156
157 void EmbeddedWorkerDispatcher::RegisterWorker( 157 void EmbeddedWorkerDispatcher::RegisterWorker(
158 int embedded_worker_id, 158 int embedded_worker_id,
159 std::unique_ptr<WorkerWrapper> wrapper) { 159 std::unique_ptr<WorkerWrapper> wrapper) {
160 workers_.AddWithID(wrapper.release(), embedded_worker_id); 160 workers_.AddWithID(std::move(wrapper), embedded_worker_id);
161 } 161 }
162 162
163 void EmbeddedWorkerDispatcher::UnregisterWorker(int embedded_worker_id) { 163 void EmbeddedWorkerDispatcher::UnregisterWorker(int embedded_worker_id) {
164 if (ContainsKey(stop_worker_times_, embedded_worker_id)) { 164 if (ContainsKey(stop_worker_times_, embedded_worker_id)) {
165 base::TimeTicks stop_time = stop_worker_times_[embedded_worker_id]; 165 base::TimeTicks stop_time = stop_worker_times_[embedded_worker_id];
166 UMA_HISTOGRAM_MEDIUM_TIMES("ServiceWorker.TerminateThread.Time", 166 UMA_HISTOGRAM_MEDIUM_TIMES("ServiceWorker.TerminateThread.Time",
167 base::TimeTicks::Now() - stop_time); 167 base::TimeTicks::Now() - stop_time);
168 stop_worker_times_.erase(embedded_worker_id); 168 stop_worker_times_.erase(embedded_worker_id);
169 } 169 }
170 workers_.Remove(embedded_worker_id); 170 workers_.Remove(embedded_worker_id);
171 } 171 }
172 172
173 void EmbeddedWorkerDispatcher::RecordStopWorkerTimer(int embedded_worker_id) { 173 void EmbeddedWorkerDispatcher::RecordStopWorkerTimer(int embedded_worker_id) {
174 WorkerWrapper* wrapper = workers_.Lookup(embedded_worker_id); 174 WorkerWrapper* wrapper = workers_.Lookup(embedded_worker_id);
175 DCHECK(wrapper); 175 DCHECK(wrapper);
176 // This should eventually call WorkerContextDestroyed. (We may need to post 176 // This should eventually call WorkerContextDestroyed. (We may need to post
177 // a delayed task to forcibly abort the worker context if we find it 177 // a delayed task to forcibly abort the worker context if we find it
178 // necessary) 178 // necessary)
179 stop_worker_times_[embedded_worker_id] = base::TimeTicks::Now(); 179 stop_worker_times_[embedded_worker_id] = base::TimeTicks::Now();
180 } 180 }
181 181
182 } // namespace content 182 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698