Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode.

content/child/push_messaging/push_provider.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/child/push_messaging/push_provider.h"
 
 #include <memory>
 
 #include "base/lazy_instance.h"
 #include "base/memory/ptr_util.h"
@@ skipping 85 matching lines @@
   return provider;
 }
 
 void PushProvider::WillStopCurrentWorkerThread() {
   delete this;
 }
 
 void PushProvider::subscribe(
     blink::WebServiceWorkerRegistration* service_worker_registration,
     const blink::WebPushSubscriptionOptions& options,
     blink::WebPushSubscriptionCallbacks* callbacks) {

[danakj, 2016/11/18 00:15:33]

and this?

   DCHECK(service_worker_registration);
   DCHECK(callbacks);
   int request_id = push_dispatcher_->GenerateRequestId(CurrentWorkerId());
-  subscription_callbacks_.AddWithID(callbacks, request_id);
+  subscription_callbacks_.AddWithID(
+      std::unique_ptr<blink::WebPushSubscriptionCallbacks>(callbacks),
+      request_id);
   int64_t service_worker_registration_id =
       GetServiceWorkerRegistrationId(service_worker_registration);
   PushSubscriptionOptions content_options;
   content_options.user_visible_only = options.userVisibleOnly;
 
   // Just treat the server key as a string of bytes and pass it to the push
   // service.
   content_options.sender_info = options.applicationServerKey.latin1();
   thread_safe_sender_->Send(new PushMessagingHostMsg_Subscribe(
       ChildProcessHost::kInvalidUniqueID, request_id,
       service_worker_registration_id, content_options));
 }
 
 void PushProvider::unsubscribe(
     blink::WebServiceWorkerRegistration* service_worker_registration,
     blink::WebPushUnsubscribeCallbacks* callbacks) {

[danakj, 2016/11/18 00:15:33]

and this?

   DCHECK(service_worker_registration);
   DCHECK(callbacks);
 
   int request_id = push_dispatcher_->GenerateRequestId(CurrentWorkerId());
-  unsubscribe_callbacks_.AddWithID(callbacks, request_id);
+  unsubscribe_callbacks_.AddWithID(
+      std::unique_ptr<blink::WebPushUnsubscribeCallbacks>(callbacks),
+      request_id);
 
   int64_t service_worker_registration_id =
       GetServiceWorkerRegistrationId(service_worker_registration);
   thread_safe_sender_->Send(new PushMessagingHostMsg_Unsubscribe(
       request_id, service_worker_registration_id));
 }
 
 void PushProvider::getSubscription(
     blink::WebServiceWorkerRegistration* service_worker_registration,
     blink::WebPushSubscriptionCallbacks* callbacks) {

[danakj, 2016/11/18 00:15:33]

and this?

   DCHECK(service_worker_registration);
   DCHECK(callbacks);
   int request_id = push_dispatcher_->GenerateRequestId(CurrentWorkerId());
-  subscription_callbacks_.AddWithID(callbacks, request_id);
+  subscription_callbacks_.AddWithID(
+      std::unique_ptr<blink::WebPushSubscriptionCallbacks>(callbacks),
+      request_id);
   int64_t service_worker_registration_id =
       GetServiceWorkerRegistrationId(service_worker_registration);
   thread_safe_sender_->Send(new PushMessagingHostMsg_GetSubscription(
       request_id, service_worker_registration_id));
 }
 
 void PushProvider::getPermissionStatus(
     blink::WebServiceWorkerRegistration* service_worker_registration,
     const blink::WebPushSubscriptionOptions& options,
     blink::WebPushPermissionStatusCallbacks* callbacks) {

[danakj, 2016/11/18 00:15:33]

and this?

   DCHECK(service_worker_registration);
   DCHECK(callbacks);
   int request_id = push_dispatcher_->GenerateRequestId(CurrentWorkerId());
-  permission_status_callbacks_.AddWithID(callbacks, request_id);
+  permission_status_callbacks_.AddWithID(
+      std::unique_ptr<blink::WebPushPermissionStatusCallbacks>(callbacks),
+      request_id);
   int64_t service_worker_registration_id =
       GetServiceWorkerRegistrationId(service_worker_registration);
   thread_safe_sender_->Send(new PushMessagingHostMsg_GetPermissionStatus(
       request_id, service_worker_registration_id, options.userVisibleOnly));
 }
 
 bool PushProvider::OnMessageReceived(const IPC::Message& message) {
   bool handled = true;
   IPC_BEGIN_MESSAGE_MAP(PushProvider, message)
     IPC_MESSAGE_HANDLER(PushMessagingMsg_SubscribeFromWorkerSuccess,
@@ skipping 131 matching lines @@
         "supported.";
   }
 
   callbacks->onError(
       blink::WebPushError(error, blink::WebString::fromUTF8(error_message)));
 
   permission_status_callbacks_.Remove(request_id);
 }
 
 }  // namespace content