Mandate unique_ptr for base::IDMap in IDMapOwnPointer mode.

android_webview/browser/aw_permission_manager.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "android_webview/browser/aw_permission_manager.h"
 
+#include <memory>
 #include <string>
 
 #include "android_webview/browser/aw_browser_permission_request_delegate.h"
 #include "base/callback.h"
 #include "base/containers/hash_tables.h"
 #include "base/logging.h"
 #include "content/public/browser/permission_type.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/web_contents.h"
@@ skipping 251 matching lines @@
           pending_request->SetPermissionStatus(
               permissions[i],
               it.GetCurrentValue()->GetPermissionStatus(permissions[i]));
         }
         should_delegate_requests[i] = false;
         break;
       }
     }
   }
 
-  int request_id = pending_requests_.Add(pending_request);
+  int request_id = pending_requests_.Add(
+      std::unique_ptr<PendingRequest>(pending_request));

[danakj, 2016/11/18 00:15:32]

base::WrapUnique?

Tho it'd be nicer to allocate into a unique_ptr above and store a raw pointer
separately. That avoids dangers of double-free by wrapping more than once.

 
   AwBrowserPermissionRequestDelegate* delegate = GetDelegate(
       pending_request->render_process_id, pending_request->render_frame_id);
 
   for (size_t i = 0; i < permissions.size(); ++i) {
     if (!should_delegate_requests[i])
       continue;
 
     if (!delegate) {
       DVLOG(0) << "Dropping permissions request for "
@@ skipping 253 matching lines @@
       ->GetLastCommittedURL().GetOrigin();
 }
 
 AwBrowserPermissionRequestDelegate* AwPermissionManager::GetDelegate(
     int render_process_id, int render_frame_id) {
   return AwBrowserPermissionRequestDelegate::FromID(render_process_id,
                                                     render_frame_id);
 }
 
 }  // namespace android_webview