Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Unified Diff: ui/aura/env.cc

Issue 2480273003: Revert of Improves focus/activation for aura-mus and DesktopNativeWidgetAura (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/aura/env.h ('k') | ui/aura/env_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/aura/env.cc
diff --git a/ui/aura/env.cc b/ui/aura/env.cc
index c4dc11d1569b22943db51962c9aa2e58bf0a1474..56714515c25f9b3c5ee471fb095136cdc5caa783 100644
--- a/ui/aura/env.cc
+++ b/ui/aura/env.cc
@@ -8,11 +8,8 @@
#include "base/lazy_instance.h"
#include "base/memory/ptr_util.h"
#include "base/threading/thread_local.h"
-#include "ui/aura/client/focus_client.h"
#include "ui/aura/env_observer.h"
#include "ui/aura/input_state_lookup.h"
-#include "ui/aura/window.h"
-#include "ui/aura/window_observer.h"
#include "ui/aura/window_port_local.h"
#include "ui/events/event_target_iterator.h"
#include "ui/events/platform/platform_event_source.h"
@@ -36,36 +33,6 @@
}
} // namespace
-
-// Observes destruction and changes of the FocusClient for a window.
-// ActiveFocusClientWindowObserver is created for the window the FocusClient is
-// associated with.
-class Env::ActiveFocusClientWindowObserver : public WindowObserver {
- public:
- explicit ActiveFocusClientWindowObserver(Window* window) : window_(window) {
- window_->AddObserver(this);
- }
- ~ActiveFocusClientWindowObserver() override { window_->RemoveObserver(this); }
-
- // WindowObserver:
- void OnWindowDestroying(Window* window) override {
- Env::GetInstance()->OnActiveFocusClientWindowDestroying();
- }
- void OnWindowPropertyChanged(Window* window,
- const void* key,
- intptr_t old) override {
- if (key != client::kFocusClientKey)
- return;
-
- // Assume if the focus client changes the window is being destroyed.
- Env::GetInstance()->OnActiveFocusClientWindowDestroying();
- }
-
- private:
- Window* window_;
-
- DISALLOW_COPY_AND_ASSIGN(ActiveFocusClientWindowObserver);
-};
////////////////////////////////////////////////////////////////////////////////
// Env, public:
@@ -118,24 +85,6 @@
mouse_button_flags_ != 0;
}
-void Env::SetActiveFocusClient(client::FocusClient* focus_client,
- Window* focus_client_root) {
- if (focus_client == active_focus_client_ &&
- focus_client_root == active_focus_client_root_) {
- return;
- }
-
- active_focus_client_window_observer_.reset();
- active_focus_client_ = focus_client;
- active_focus_client_root_ = focus_client_root;
- if (focus_client_root) {
- active_focus_client_window_observer_ =
- base::MakeUnique<ActiveFocusClientWindowObserver>(focus_client_root);
- }
- for (EnvObserver& observer : observers_)
- observer.OnActiveFocusClientChanged(focus_client, focus_client_root);
-}
-
////////////////////////////////////////////////////////////////////////////////
// Env, private:
@@ -177,10 +126,6 @@
observer.OnHostActivated(host);
}
-void Env::OnActiveFocusClientWindowDestroying() {
- SetActiveFocusClient(nullptr, nullptr);
-}
-
////////////////////////////////////////////////////////////////////////////////
// Env, ui::EventTarget implementation:
« no previous file with comments | « ui/aura/env.h ('k') | ui/aura/env_observer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698