Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 248026: Fixing signed/unsigned mismatch warning showing up in gyp build.... (Closed)

Created:
11 years, 2 months ago by bradn
Modified:
9 years, 7 months ago
Reviewers:
gman1
CC:
o3d-review_googlegroups.com
Visibility:
Public.

Description

Fixing signed/unsigned mismatch warning showing up in gyp build. BUG=None TEST=None TBR=gman Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27431

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M command_buffer/common/cross/cmd_buffer_format.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
bradn
11 years, 2 months ago (2009-09-28 23:11:32 UTC) #1
bradn
Submitting TBR to fix redness from 27321.
11 years, 2 months ago (2009-09-28 23:26:43 UTC) #2
gman
11 years, 2 months ago (2009-09-28 23:40:39 UTC) #3
LGTM

Is there some reason not to turn on the same warnings in the scons build?

Powered by Google App Engine
This is Rietveld 408576698