Issue 248026: Fixing signed/unsigned mismatch warning showing up in gyp build....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 248026: Fixing signed/unsigned mismatch warning showing up in gyp build.... (Closed)

Created:
11 years, 2 months ago by bradn

Modified:
9 years, 7 months ago

Reviewers:
gman1

CC:
o3d-review_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/o3d/

Visibility:
Public.

Fixing signed/unsigned mismatch warning showing up in gyp build. BUG=None TEST=None TBR=gman Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=27431

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	command_buffer/common/cross/cmd_buffer_format.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

gman

11 years, 2 months ago (2009-09-28 23:40:39 UTC) #3

LGTM

Is there some reason not to turn on the same warnings in the scons build?