src/interpreter/bytecode-generator.cc - Issue 2480253006: Only treat lookup-slot-calls going through 'with' special

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/interpreter/bytecode-generator.cc

Issue 2480253006: Only treat lookup-slot-calls going through 'with' special (Closed)

Patch Set: Rebaseline expectations Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/interpreter/bytecode-generator.cc

diff --git a/src/interpreter/bytecode-generator.cc b/src/interpreter/bytecode-generator.cc

index f66dba1962cc5ffd53af6d626d6f4c8464fefae3..756b8d1f1225688ae9c1190e032c6355cf6f6d18 100644

--- a/src/interpreter/bytecode-generator.cc

+++ b/src/interpreter/bytecode-generator.cc

@@ -2391,7 +2391,7 @@ void BytecodeGenerator::VisitCall(Call* expr) {

builder()->StoreAccumulatorInRegister(callee);

break;

}

- case Call::LOOKUP_SLOT_CALL:

+ case Call::WITH_CALL:

case Call::POSSIBLY_EVAL_CALL: {

if (callee_expr->AsVariableProxy()->var()->IsLookupSlot()) {

RegisterAllocationScope inner_register_scope(this);