[ios] Adds unittests for blocks and NSRegularExpression.

ios/chrome/common/ns_regular_expression_unittest.mm

Index: ios/chrome/common/ns_regular_expression_unittest.mm
diff --git a/ios/chrome/common/ns_regular_expression_unittest.mm b/ios/chrome/common/ns_regular_expression_unittest.mm
new file mode 100644
index 0000000000000000000000000000000000000000..686f8f772a9b1dfa58acf1513869fedad7dd3ec7
--- /dev/null
+++ b/ios/chrome/common/ns_regular_expression_unittest.mm
@@ -0,0 +1,133 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/strings/sys_string_conversions.h"
+#import "testing/gtest_mac.h"
+#include "testing/platform_test.h"
+
+// Chromium code relies on NSRegularExpression class to match regular
+// expressions.  Any subtle changes in behavior can lead to hard to diagnose
+// problems.  This files tests how NSRegularExpression handles various regular
+// expression features.
+
+namespace {
+
+// Checks that capture groups from |testString| substituted into
+// |templateString| matches |expected|.
+void ExpectRegexMatched(NSRegularExpression* regex,
+                        NSString* testString,
+                        NSString* templateString,
+                        NSString* expected) {
+  NSRange testRange = NSMakeRange(0, [testString length]);
+  NSString* outputString =
+      [regex stringByReplacingMatchesInString:testString
+                                      options:0
+                                        range:testRange
+                                 withTemplate:templateString];
+  EXPECT_TRUE(outputString && [outputString isEqualToString:expected])
+      << "ExpectRegexMatched: '" << base::SysNSStringToUTF8(expected) << "' != "
+      << (!outputString ? "(nil)"
+                        : "'" + base::SysNSStringToUTF8(outputString) + "'");
+}
+
+// Checks that |testString| is not matched by |regex|.
+void ExpectRegexNotMatched(NSRegularExpression* regex, NSString* testString) {
+  __block BOOL matched = NO;
+  NSRange testRange = NSMakeRange(0, [testString length]);
+  [regex enumerateMatchesInString:testString
+                          options:0
+                            range:testRange
+                       usingBlock:^(NSTextCheckingResult* result,
+                                    NSMatchingFlags flags, BOOL* stop) {
+                         if (NSEqualRanges([result range], testRange)) {
+                           *stop = YES;
+                           matched = YES;
+                         }
+                       }];
+  EXPECT_FALSE(matched) << "ExpectRegexNotMatched: '"
+                        << base::SysNSStringToUTF8(testString) << "' "
+                        << "pattern:"
+                        << base::SysNSStringToUTF8([regex pattern]);
+}
+
+// Returns an autoreleased NSRegularExpression object from the regular
+// expression |pattern|.
+NSRegularExpression* MakeRegularExpression(NSString* pattern) {
+  NSError* error = nil;
+  return [NSRegularExpression regularExpressionWithPattern:pattern
+                                                   options:0
+                                                     error:&error];
+}
+
+TEST(NSRegularExpressionTest, TestSimpleRegex) {
+  NSRegularExpression* regex = MakeRegularExpression(@"foo(.*)bar(.*)");
+  ExpectRegexMatched(regex, @"fooONEbarTWO", @"first $1, second $2",
+                     @"first ONE, second TWO");
+}
+
+TEST(NSRegularExpressionTest, TestComplexRegex) {
+  NSString* expression = @"^http[s]?://"
+                          "(?:"
+                          "(?:youtu\\.be/)|"
+                          "(?:.*\\.youtube\\.com/watch\\?v=)|"
+                          "(?:.*\\.youtube\\.com/index\\?)"
+                          ")"
+                          "([^&]*)[\\&]?(?:.*)$";
+  NSString* templateString = @"vnd.youtube://$1";
+  NSString* expectedOutput = @"vnd.youtube://ndRXe3tTnsA";
+  NSRegularExpression* regex = MakeRegularExpression(expression);
+  ExpectRegexMatched(regex, @"http://youtu.be/ndRXe3tTnsA", templateString,
+                     expectedOutput);
+  ExpectRegexMatched(regex, @"http://www.youtube.com/watch?v=ndRXe3tTnsA",
+                     templateString, expectedOutput);
+  ExpectRegexNotMatched(regex, @"http://www.google.com");
+  ExpectRegexNotMatched(regex, @"http://www.youtube.com/embed/GkOZ8DfO248");
+}
+
+TEST(NSRegularExpressionTest, TestSimpleAlternation) {
+  // This test verifies how NSRegularExpression works.
+  // Regex 'ab|c' matches 'ab', 'ac', or 'c'. Does not match 'abc', 'a', or 'b'.
+  NSRegularExpression* regex = MakeRegularExpression(@"^ab|c$");
+  ExpectRegexMatched(regex, @"ab", @"$0", @"ab");
+  ExpectRegexMatched(regex, @"c", @"$0", @"c");
+  ExpectRegexMatched(regex, @"ac", @"$0", @"ac");

[pkl (ping after 24h if needed), 2016/11/08 23:54:13]

I think this may be where ICU Regular Expressions and NS Regular Expressions
differs.

Looking at the old test on
https://chromereviews.googleplex.com/9582014/diff/7001/ios_internal/chrome/co...,
I can see that RegEx "ab|c" does not match "ac", i.e.
  ExpectRegexNotMatched(regex.get(), @"ac", @"$0");

It's likely that the migration from ICU to NS we fixed the test to match
NSRegularExpression behavior but failed to update the comments.

The comments and test code in this CL are both correct.

[rohitrao (ping after 24h), 2016/11/15 14:04:38]

Acknowledged.

+  ExpectRegexNotMatched(regex, @"abc");
+  ExpectRegexNotMatched(regex, @"a");
+  ExpectRegexNotMatched(regex, @"b");
+
+  // Regex 'ab|c' behaves the same as '(?:ab)|(?:c)'
+  regex = MakeRegularExpression(@"^(?:ab)|(?:c)$");
+  ExpectRegexMatched(regex, @"ab", @"$0", @"ab");
+  ExpectRegexMatched(regex, @"c", @"$0", @"c");
+  ExpectRegexNotMatched(regex, @"ac");
+  ExpectRegexNotMatched(regex, @"abc");
+
+  // This other regex: 'a(b|c)' matches either 'ab' or 'ac'.
+  regex = MakeRegularExpression(@"^a(?:b|c)$");
+  ExpectRegexMatched(regex, @"ab", @"$0", @"ab");
+  ExpectRegexMatched(regex, @"ac", @"$0", @"ac");
+  ExpectRegexNotMatched(regex, @"a");
+  ExpectRegexNotMatched(regex, @"abc");
+}
+
+TEST(NSRegularExpressionTest, TestUberCaptureGroup) {
+  // The absence of an uber-capture group caused NSRegularExpression to crash on
+  // iOS 5.x. This tests to make sure that it is not happening on iOS 6+
+  // environments.
+  NSRegularExpression* regex = MakeRegularExpression(@"^(ab|cd|ef)ghij$");
+  ExpectRegexMatched(regex, @"abghij", @"$0", @"abghij");
+  ExpectRegexMatched(regex, @"cdghij", @"$0", @"cdghij");
+  ExpectRegexMatched(regex, @"efghij", @"$0", @"efghij");
+  ExpectRegexNotMatched(regex, @"abcdefghij");
+
+  regex = MakeRegularExpression(@"^ab|cd|efghij$");
+  ExpectRegexMatched(regex, @"ab", @"$0", @"ab");
+  ExpectRegexMatched(regex, @"cd", @"$0", @"cd");
+  ExpectRegexMatched(regex, @"efghij", @"$0", @"efghij");
+  ExpectRegexNotMatched(regex, @"abcdefghij");
+  ExpectRegexNotMatched(regex, @"abghij");
+  ExpectRegexNotMatched(regex, @"cdghij");
+}
+
+}  // namespace