Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura_unittest.cc

Issue 2480203002: ui: Cleanup class/struct forward declarations (Closed)
Patch Set: Sync CL to position 430550 Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc b/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
index 3cabe3e2db1cda955bb6be3903c1d8550f6843b6..4172bf24b829f6c3626e009b0057b5d08f08f75a 100644
--- a/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
+++ b/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc
@@ -583,7 +583,7 @@ class RenderWidgetHostViewAuraTest : public testing::Test {
void SendInputEventACK(WebInputEvent::Type type,
InputEventAckState ack_result) {
DCHECK(!WebInputEvent::isTouchEventType(type));
- InputEventAck ack(type, ack_result);
+ InputEventAck ack(InputEventAckSource::COMPOSITOR_THREAD, type, ack_result);
InputHostMsg_HandleInputEvent_ACK response(0, ack);
widget_host_->OnMessageReceived(response);
}
@@ -592,7 +592,8 @@ class RenderWidgetHostViewAuraTest : public testing::Test {
InputEventAckState ack_result,
uint32_t event_id) {
DCHECK(WebInputEvent::isTouchEventType(type));
- InputEventAck ack(type, ack_result, event_id);
+ InputEventAck ack(InputEventAckSource::COMPOSITOR_THREAD, type, ack_result,
+ event_id);
InputHostMsg_HandleInputEvent_ACK response(0, ack);
widget_host_->OnMessageReceived(response);
}
@@ -1342,9 +1343,9 @@ TEST_F(RenderWidgetHostViewAuraTest, TouchEventState) {
widget_host_->OnMessageReceived(ViewHostMsg_HasTouchEventHandlers(0, false));
// Ack'ing the outstanding event should flush the pending touch queue.
- InputEventAck ack(blink::WebInputEvent::TouchStart,
- INPUT_EVENT_ACK_STATE_NO_CONSUMER_EXISTS,
- press.unique_event_id());
+ InputEventAck ack(
+ InputEventAckSource::COMPOSITOR_THREAD, blink::WebInputEvent::TouchStart,
+ INPUT_EVENT_ACK_STATE_NO_CONSUMER_EXISTS, press.unique_event_id());
widget_host_->OnMessageReceived(InputHostMsg_HandleInputEvent_ACK(0, ack));
EXPECT_EQ(0U, GetSentMessageCountAndResetSink());
@@ -1514,7 +1515,11 @@ TEST_F(RenderWidgetHostViewAuraTest, PhysicalBackingSizeWithScale) {
aura_test_helper_->test_screen()->SetDeviceScaleFactor(2.0f);
EXPECT_EQ("200x200", view_->GetPhysicalBackingSize().ToString());
// Extra ScreenInfoChanged message for |parent_view_|.
- EXPECT_EQ(0u, sink_->message_count());
+ // Changing the device scale factor triggers the
+ // RenderWidgetHostViewAura::OnDisplayMetricsChanged() observer callback,
+ // which sends a ViewMsg_Resize::ID message to the renderer.
+ EXPECT_EQ(1u, sink_->message_count());
+ EXPECT_EQ(ViewMsg_Resize::ID, sink_->GetMessageAt(0)->type());
auto view_delegate = static_cast<MockRenderWidgetHostDelegate*>(
static_cast<RenderWidgetHostImpl*>(view_->GetRenderWidgetHost())
->delegate());
@@ -1525,7 +1530,8 @@ TEST_F(RenderWidgetHostViewAuraTest, PhysicalBackingSizeWithScale) {
aura_test_helper_->test_screen()->SetDeviceScaleFactor(1.0f);
// Extra ScreenInfoChanged message for |parent_view_|.
- EXPECT_EQ(0u, sink_->message_count());
+ EXPECT_EQ(1u, sink_->message_count());
+ EXPECT_EQ(ViewMsg_Resize::ID, sink_->GetMessageAt(0)->type());
EXPECT_EQ(1.0f, view_delegate->get_last_device_scale_factor());
EXPECT_EQ("100x100", view_->GetPhysicalBackingSize().ToString());
}
@@ -4128,24 +4134,6 @@ TEST_F(RenderWidgetHostViewAuraTest, ForwardMouseEvent) {
view_ = nullptr;
}
-// Tests the RenderWidgetHostImpl sends the correct surface ID namespace to
-// the renderer process.
-TEST_F(RenderWidgetHostViewAuraTest, FrameSinkIdInitialized) {
- gfx::Size size(5, 5);
-
- const IPC::Message* msg =
- sink_->GetUniqueMessageMatching(ViewMsg_SetFrameSinkId::ID);
- EXPECT_TRUE(msg);
- ViewMsg_SetFrameSinkId::Param params;
- ViewMsg_SetFrameSinkId::Read(msg, &params);
- view_->InitAsChild(nullptr);
- view_->Show();
- view_->SetSize(size);
- view_->OnSwapCompositorFrame(0,
- MakeDelegatedFrame(1.f, size, gfx::Rect(size)));
- EXPECT_EQ(view_->GetFrameSinkId(), std::get<0>(params));
-}
-
// This class provides functionality to test a RenderWidgetHostViewAura
// instance which has been hooked up to a test RenderViewHost instance and
// a WebContents instance.

Powered by Google App Engine
This is Rietveld 408576698