| Index: device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc
|
| diff --git a/device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc b/device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc
|
| index 97ac1d8fc9780bb2cb7aa6303c44220fc49a0d5b..4adae36c00468164e96d32be08989d6c9a098805 100644
|
| --- a/device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc
|
| +++ b/device/bluetooth/bluetooth_remote_gatt_characteristic_unittest.cc
|
| @@ -366,7 +366,7 @@ TEST_F(BluetoothRemoteGattCharacteristicTest,
|
|
|
| characteristic1_->ReadRemoteCharacteristic(
|
| GetReadValueCallback(Call::NOT_EXPECTED),
|
| - GetGattErrorCallback(Call::NOT_EXPECTED));
|
| + GetGattErrorCallback(Call::EXPECTED));
|
|
|
| RememberCharacteristicForSubsequentAction(characteristic1_);
|
| DeleteDevice(device_); // TODO(576906) delete only the characteristic.
|
| @@ -378,8 +378,9 @@ TEST_F(BluetoothRemoteGattCharacteristicTest,
|
| }
|
| #endif // defined(OS_ANDROID) || defined(OS_WIN)
|
|
|
| -// TODO(crbug.com/621901): Enable test on all platforms.
|
| -#if defined(OS_MACOSX)
|
| +// TODO(crbug.com/663131): Enable test on windows when disconnection is
|
| +// implemented.
|
| +#if defined(OS_ANDROID) || defined(OS_MACOSX)
|
| TEST_F(BluetoothRemoteGattCharacteristicTest,
|
| ReadRemoteCharacteristic_Disconnected) {
|
| if (!PlatformSupportsLowEnergy()) {
|
| @@ -415,7 +416,7 @@ TEST_F(BluetoothRemoteGattCharacteristicTest,
|
| empty_vector);
|
| #endif
|
| }
|
| -#endif // defined(OS_MACOSX)
|
| +#endif // defined(OS_ANDROID) || defined(OS_MACOSX)
|
|
|
| #if defined(OS_ANDROID) || defined(OS_WIN)
|
| // Tests WriteRemoteCharacteristic completing after Chrome objects are deleted.
|
| @@ -433,7 +434,7 @@ TEST_F(BluetoothRemoteGattCharacteristicTest,
|
| std::vector<uint8_t> empty_vector;
|
| characteristic1_->WriteRemoteCharacteristic(
|
| empty_vector, GetCallback(Call::NOT_EXPECTED),
|
| - GetGattErrorCallback(Call::NOT_EXPECTED));
|
| + GetGattErrorCallback(Call::EXPECTED));
|
|
|
| RememberCharacteristicForSubsequentAction(characteristic1_);
|
| DeleteDevice(device_); // TODO(576906) delete only the characteristic.
|
| @@ -443,8 +444,9 @@ TEST_F(BluetoothRemoteGattCharacteristicTest,
|
| }
|
| #endif // defined(OS_ANDROID) || defined(OS_WIN)
|
|
|
| -// TODO(crbug.com/621901): Enable test on all platforms.
|
| -#if defined(OS_MACOSX)
|
| +// TODO(crbug.com/663131): Enable test on windows when disconnection is
|
| +// implemented.
|
| +#if defined(OS_ANDROID) || defined(OS_MACOSX)
|
| TEST_F(BluetoothRemoteGattCharacteristicTest,
|
| WriteRemoteCharacteristic_Disconnected) {
|
| if (!PlatformSupportsLowEnergy()) {
|
| @@ -479,7 +481,7 @@ TEST_F(BluetoothRemoteGattCharacteristicTest,
|
| SimulateGattCharacteristicWrite(/* use remembered characteristic */ nullptr);
|
| #endif // !defined(OS_MACOSX)
|
| }
|
| -#endif // defined(OS_MACOSX)
|
| +#endif // defined(OS_ANDROID) || defined(OS_MACOSX)
|
|
|
| #if defined(OS_ANDROID) || defined(OS_MACOSX) || defined(OS_WIN)
|
| // Tests ReadRemoteCharacteristic and GetValue with non-empty value buffer.
|
|
|