chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer.h - Issue 2480203002: ui: Cleanup class/struct forward declarations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer.h

Issue 2480203002: ui: Cleanup class/struct forward declarations (Closed)

Patch Set: Sync CL to position 430550 Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ntp_snippets/download_suggestions_provider.cc ('k') | chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer.h

diff --git a/chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer.h b/chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer.h

index 51b48c1020e3a444ddb7d59b311ad0ca11073c59..369d8d11022eb2834e741db286ad135b684f605d 100644

--- a/chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer.h

+++ b/chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer.h

@@ -15,7 +15,16 @@ class ProtocolPageLoadMetricsObserver

ProtocolPageLoadMetricsObserver() = default;

// page_load_metrics::PageLoadMetricsObserver implementation:

+ ObservePolicy OnStart(content::NavigationHandle* navigation_handle,

+ const GURL& currently_committed_url,

+ bool started_in_foreground) override;

ObservePolicy OnCommit(content::NavigationHandle* navigation_handle) override;

+ ObservePolicy OnHidden(

+ const page_load_metrics::PageLoadTiming& timing,

+ const page_load_metrics::PageLoadExtraInfo& info) override;

+ void OnParseStart(

+ const page_load_metrics::PageLoadTiming& timing,

+ const page_load_metrics::PageLoadExtraInfo& extra_info) override;

void OnFirstContentfulPaint(

const page_load_metrics::PageLoadTiming& timing,

const page_load_metrics::PageLoadExtraInfo& extra_info) override;