Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5345)

Unified Diff: components/browser_sync/profile_sync_service.h

Issue 2480203002: ui: Cleanup class/struct forward declarations (Closed)
Patch Set: Sync CL to position 430550 Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/browser_sync/profile_sync_service.h
diff --git a/components/browser_sync/profile_sync_service.h b/components/browser_sync/profile_sync_service.h
index aea88e76a7f8975be38b2266e731022c813cf79d..7dfd9dee7ac284104dd9f6d1f4cb9c0ca945fed4 100644
--- a/components/browser_sync/profile_sync_service.h
+++ b/components/browser_sync/profile_sync_service.h
@@ -921,11 +921,10 @@ class ProfileSyncService : public syncer::SyncService,
// and association information.
syncer::WeakHandle<syncer::DataTypeDebugInfoListener> debug_info_listener_;
- // A thread where all the sync operations happen.
- // OWNERSHIP Notes:
- // * Created when backend starts for the first time.
- // * If sync is disabled, PSS claims ownership from backend.
- // * If sync is reenabled, PSS passes ownership to new backend.
+ // The thread where all the sync operations happen. This thread is kept alive
+ // until browser shutdown and reused if sync is turned off and on again. It is
+ // joined during the shutdown process, but there is an abort mechanism in
+ // place to prevent slow HTTP requests from blocking browser shutdown.
std::unique_ptr<base::Thread> sync_thread_;
// ProfileSyncService uses this service to get access tokens.
« no previous file with comments | « components/autofill/core/common/save_password_progress_logger.cc ('k') | components/browser_sync/profile_sync_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698