Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java

Issue 2480203002: ui: Cleanup class/struct forward declarations (Closed)
Patch Set: Sync CL to position 430550 Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java b/chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java
index 08352feadb8a4ea130befe07a285a325481281ad..9f0cc2b6cfb9994d62c56c92d9ebf09122dc07d0 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java
@@ -47,6 +47,7 @@ import android.widget.TextView;
import org.chromium.base.ApiCompatibilityUtils;
import org.chromium.base.annotations.CalledByNative;
+import org.chromium.base.metrics.RecordHistogram;
import org.chromium.base.metrics.RecordUserAction;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.ContentSettingsType;
@@ -484,7 +485,12 @@ public class WebsiteSettingsPopup implements OnClickListener {
mSiteSettingsButton.setVisibility(View.GONE);
}
- if (!isShowingOfflinePage() || !OfflinePageUtils.isConnected()) {
+ if (isShowingOfflinePage()) {
+ boolean isConnected = OfflinePageUtils.isConnected();
+ RecordHistogram.recordBooleanHistogram(
+ "OfflinePages.WebsiteSettings.OpenOnlineButtonVisible", isConnected);
+ if (!isConnected) mOpenOnlineButton.setVisibility(View.GONE);
+ } else {
mOpenOnlineButton.setVisibility(View.GONE);
}
@@ -801,6 +807,9 @@ public class WebsiteSettingsPopup implements OnClickListener {
// Attempt to reload to an online version of the viewed offline web page. This
// attempt might fail if the user is offline, in which case an offline copy will
// be reloaded.
+ RecordHistogram.recordBooleanHistogram(
+ "OfflinePages.WebsiteSettings.ConnectedWhenOpenOnlineButtonClicked",
+ OfflinePageUtils.isConnected());
OfflinePageUtils.reload(mTab);
}
});

Powered by Google App Engine
This is Rietveld 408576698