Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Unified Diff: chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.cc

Issue 2480203002: ui: Cleanup class/struct forward declarations (Closed)
Patch Set: Sync CL to position 430550 Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.cc
diff --git a/chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.cc b/chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.cc
index d2fe421f4839202f1bebea1710055657239c34aa..94ad027ee302394d1bd499f26a2438c58e062281 100644
--- a/chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.cc
+++ b/chrome/browser/chromeos/arc/intent_helper/arc_external_protocol_dialog.cc
@@ -204,7 +204,8 @@ bool HandleUrl(int render_process_host_id,
return false;
}
-// Called when the dialog is closed.
+// Called when the dialog is closed. Note that once we show the UI, we should
+// never show the Chrome OS' fallback dialog.
void OnIntentPickerClosed(int render_process_host_id,
int routing_id,
const GURL& url,
@@ -258,9 +259,8 @@ void OnIntentPickerClosed(int render_process_host_id,
// fall through.
}
case ArcNavigationThrottle::CloseReason::DIALOG_DEACTIVATED: {
- // The user didn't select any ARC activity. Show the Chrome OS dialog.
- ShowFallbackExternalProtocolDialog(render_process_host_id, routing_id,
- url);
+ // The user didn't select any ARC activity.
+ CloseTabIfNeeded(render_process_host_id, routing_id);
break;
}
}

Powered by Google App Engine
This is Rietveld 408576698