Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1052)

Unified Diff: content/browser/devtools/protocol/devtools_protocol_handler_generator.py

Issue 2480203002: ui: Cleanup class/struct forward declarations (Closed)
Patch Set: Sync CL to position 430550 Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/protocol/devtools_protocol_handler_generator.py
diff --git a/content/browser/devtools/protocol/devtools_protocol_handler_generator.py b/content/browser/devtools/protocol/devtools_protocol_handler_generator.py
index f08ea9e5f085868793be5f34989638ad94ebd11c..7b0f58c2d2f28f93b70058043efe25c6ff130423 100755
--- a/content/browser/devtools/protocol/devtools_protocol_handler_generator.py
+++ b/content/browser/devtools/protocol/devtools_protocol_handler_generator.py
@@ -657,6 +657,24 @@ browser_commands_list = [
"Network.setCookie",
"Network.canEmulateNetworkConditions",
"Network.emulateNetworkConditions"]
+async_commands_list = [
+ "Page.getResourceContent",
+ "Page.searchInResource",
+ "Page.captureScreenshot",
+ "Network.getCookies",
+ "Network.deleteCookie",
+ "Network.setCookie",
+ "IO.read",
+ "Input.synthesizePinchGesture",
+ "Input.synthesizeScrollGesture",
+ "Input.synthesizeTapGesture",
+ "Tracing.start",
+ "Tracing.end",
+ "Tracing.getCategories",
+ "Tracing.requestMemoryDump",
+ "SystemInfo.getInfo",
+ "Tethering.bind",
+ "Tethering.unbind"]
for json_domain in all_domains:
domain_map = {}
@@ -719,7 +737,7 @@ for json_domain in all_domains:
args.append(
tmpl_arg_req.substitute(param_map, param_pass=param_pass))
- if json_command.get("async"):
+ if full_command_name in async_commands_list:
domain_needs_client = True
json_returns = []
if "returns" in json_command:

Powered by Google App Engine
This is Rietveld 408576698