Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1765)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java

Issue 2480203002: ui: Cleanup class/struct forward declarations (Closed)
Patch Set: Sync CL to position 430550 Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java
index 32e0d24cb77aba935613502656abcfb0f955e67c..c5162bf5837bbaca5b3cbcf8775e8e91d8de0276 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebApkInstaller.java
@@ -5,17 +5,14 @@
package org.chromium.chrome.browser.webapps;
import android.content.ActivityNotFoundException;
-import android.content.Context;
import android.content.Intent;
import android.content.pm.PackageManager;
import android.net.Uri;
import android.os.Looper;
-import android.provider.Settings;
import org.chromium.base.ApplicationState;
import org.chromium.base.ApplicationStatus;
import org.chromium.base.ContextUtils;
-import org.chromium.base.Log;
import org.chromium.base.annotations.CalledByNative;
import org.chromium.chrome.browser.ShortcutHelper;
import org.chromium.chrome.browser.banners.InstallerDelegate;
@@ -70,11 +67,6 @@ public class WebApkInstaller {
@CalledByNative
private boolean installAsyncAndMonitorInstallationFromNative(
String filePath, String packageName) {
- if (!installingFromUnknownSourcesAllowed()) {
- Log.e(TAG,
- "WebAPK install failed because installation from unknown sources is disabled.");
- return false;
- }
mIsInstall = true;
mWebApkPackageName = packageName;
@@ -137,30 +129,10 @@ public class WebApkInstaller {
*/
@CalledByNative
private boolean updateAsyncFromNative(String filePath) {
- if (!installingFromUnknownSourcesAllowed()) {
- Log.e(TAG,
- "WebAPK update failed because installation from unknown sources is disabled.");
- return false;
- }
mIsInstall = false;
return installDownloadedWebApk(filePath);
}
- /**
- * Returns whether the user has enabled installing apps from sources other than the Google Play
- * Store.
- */
- private static boolean installingFromUnknownSourcesAllowed() {
- Context context = ContextUtils.getApplicationContext();
- try {
- return Settings.Secure.getInt(
- context.getContentResolver(), Settings.Secure.INSTALL_NON_MARKET_APPS)
- == 1;
- } catch (Settings.SettingNotFoundException e) {
- return false;
- }
- }
-
private ApplicationStatus.ApplicationStateListener createApplicationStateListener() {
return new ApplicationStatus.ApplicationStateListener() {
@Override

Powered by Google App Engine
This is Rietveld 408576698