Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Unified Diff: content/browser/browser_main_loop.cc

Issue 2480203002: ui: Cleanup class/struct forward declarations (Closed)
Patch Set: Sync CL to position 430550 Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/bad_message.h ('k') | content/browser/child_process_launcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/browser_main_loop.cc
diff --git a/content/browser/browser_main_loop.cc b/content/browser/browser_main_loop.cc
index f4b7eae0ba294a5cd96d7e39655eff0555045ddd..648873d6c243ff38638dfb43e33d088dd150381f 100644
--- a/content/browser/browser_main_loop.cc
+++ b/content/browser/browser_main_loop.cc
@@ -350,12 +350,12 @@ MSVC_ENABLE_OPTIMIZE();
#if defined(OS_WIN)
// Creates a memory pressure monitor using automatic thresholds, or those
// specified on the command-line. Ownership is passed to the caller.
-base::win::MemoryPressureMonitor* CreateWinMemoryPressureMonitor(
- const base::CommandLine& parsed_command_line) {
- std::vector<std::string> thresholds = base::SplitString(
- parsed_command_line.GetSwitchValueASCII(
- switches::kMemoryPressureThresholdsMb),
- ",", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
+std::unique_ptr<base::win::MemoryPressureMonitor>
+CreateWinMemoryPressureMonitor(const base::CommandLine& parsed_command_line) {
+ std::vector<std::string> thresholds =
+ base::SplitString(parsed_command_line.GetSwitchValueASCII(
+ switches::kMemoryPressureThresholdsMb),
+ ",", base::TRIM_WHITESPACE, base::SPLIT_WANT_ALL);
int moderate_threshold_mb = 0;
int critical_threshold_mb = 0;
@@ -364,12 +364,12 @@ base::win::MemoryPressureMonitor* CreateWinMemoryPressureMonitor(
base::StringToInt(thresholds[1], &critical_threshold_mb) &&
moderate_threshold_mb >= critical_threshold_mb &&
critical_threshold_mb >= 0) {
- return new base::win::MemoryPressureMonitor(moderate_threshold_mb,
- critical_threshold_mb);
+ return base::MakeUnique<base::win::MemoryPressureMonitor>(
+ moderate_threshold_mb, critical_threshold_mb);
}
// In absence of valid switches use the automatic defaults.
- return new base::win::MemoryPressureMonitor();
+ return base::MakeUnique<base::win::MemoryPressureMonitor>();
}
#endif // defined(OS_WIN)
@@ -1399,6 +1399,22 @@ bool BrowserMainLoop::UsingInProcessGpu() const {
}
void BrowserMainLoop::InitializeMemoryManagementComponent() {
+ // TODO(chrisha): Abstract away this construction mess to a helper function,
+ // once MemoryPressureMonitor is made a concrete class.
+#if defined(OS_CHROMEOS)
+ if (chromeos::switches::MemoryPressureHandlingEnabled()) {
+ memory_pressure_monitor_ =
+ base::MakeUnique<base::chromeos::MemoryPressureMonitor>(
+ chromeos::switches::GetMemoryPressureThresholds());
+ }
+#elif defined(OS_MACOSX)
+ memory_pressure_monitor_ =
+ base::MakeUnique<base::mac::MemoryPressureMonitor>();
+#elif defined(OS_WIN)
+ memory_pressure_monitor_ =
+ CreateWinMemoryPressureMonitor(parsed_command_line_);
+#endif
+
if (base::FeatureList::IsEnabled(features::kMemoryCoordinator)) {
// Disable MemoryPressureListener when memory coordinator is enabled.
base::MemoryPressureListener::SetNotificationsSuppressed(true);
@@ -1412,22 +1428,13 @@ void BrowserMainLoop::InitializeMemoryManagementComponent() {
SetSetCurrentMemoryStateForTestingCallback(base::Bind(
&MemoryCoordinator::SetCurrentMemoryStateForTesting,
base::Unretained(MemoryCoordinator::GetInstance())));
- return;
- }
- // TODO(chrisha): Abstract away this construction mess to a helper function,
- // once MemoryPressureMonitor is made a concrete class.
-#if defined(OS_CHROMEOS)
- if (chromeos::switches::MemoryPressureHandlingEnabled()) {
- memory_pressure_monitor_.reset(new base::chromeos::MemoryPressureMonitor(
- chromeos::switches::GetMemoryPressureThresholds()));
+ if (memory_pressure_monitor_) {
+ memory_pressure_monitor_->SetDispatchCallback(
+ base::Bind(&MemoryCoordinator::RecordMemoryPressure,
+ base::Unretained(MemoryCoordinator::GetInstance())));
+ }
}
-#elif defined(OS_MACOSX)
- memory_pressure_monitor_.reset(new base::mac::MemoryPressureMonitor());
-#elif defined(OS_WIN)
- memory_pressure_monitor_.reset(CreateWinMemoryPressureMonitor(
- parsed_command_line_));
-#endif
}
bool BrowserMainLoop::InitializeToolkit() {
« no previous file with comments | « content/browser/bad_message.h ('k') | content/browser/child_process_launcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698