Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3179)

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js

Issue 2480203002: ui: Cleanup class/struct forward declarations (Closed)
Patch Set: Sync CL to position 430550 Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js
diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js
index 9cda6fcc6539795a73411af4184b9f061ac35488..dfbd273d00c9ef9563fdb30dfbcebf2fffd4e319 100644
--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js
+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_predicate.js
@@ -104,6 +104,7 @@ AutomationPredicate.formField = AutomationPredicate.match({
Role.listBox,
Role.slider,
Role.switch,
+ Role.tab,
Role.tree
]
});
@@ -119,8 +120,7 @@ AutomationPredicate.control = AutomationPredicate.match({
Role.menuItemCheckBox,
Role.menuItemRadio,
Role.menuListOption,
- Role.scrollBar,
- Role.tab
+ Role.scrollBar
]
});
@@ -301,6 +301,7 @@ AutomationPredicate.container = function(node) {
*/
AutomationPredicate.structuralContainer = AutomationPredicate.roles([
Role.rootWebArea,
+ Role.webView,
Role.embeddedObject,
Role.iframe,
Role.iframePresentational]);
@@ -345,8 +346,8 @@ AutomationPredicate.shouldIgnoreNode = function(node) {
if (node.role == Role.listMarker)
return true;
- // Don't ignore nodes with names.
- if (node.name || node.value || node.description)
+ // Don't ignore nodes with names or name-like attribute.
+ if (node.name || node.value || node.description || node.url)
return false;
// Ignore some roles.

Powered by Google App Engine
This is Rietveld 408576698