Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(775)

Unified Diff: content/browser/service_worker/service_worker_url_request_job.cc

Issue 2480203002: ui: Cleanup class/struct forward declarations (Closed)
Patch Set: Sync CL to position 430550 Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_url_request_job.cc
diff --git a/content/browser/service_worker/service_worker_url_request_job.cc b/content/browser/service_worker/service_worker_url_request_job.cc
index 2f852939088c0ae4f6fc15753280a7599f56b06b..6d0fe9edafa23d4908fa0f8f6ea97a73fc0b0e62 100644
--- a/content/browser/service_worker/service_worker_url_request_job.cc
+++ b/content/browser/service_worker/service_worker_url_request_job.cc
@@ -366,9 +366,7 @@ void ServiceWorkerURLRequestJob::RecordResult(
}
did_record_result_ = true;
ServiceWorkerMetrics::RecordURLRequestJobResult(IsMainResourceLoad(), result);
- if (request()) {
- request()->net_log().AddEvent(RequestJobResultToNetEventType(result));
- }
+ request()->net_log().AddEvent(RequestJobResultToNetEventType(result));
}
base::WeakPtr<ServiceWorkerURLRequestJob>
@@ -584,12 +582,6 @@ void ServiceWorkerURLRequestJob::DidDispatchFetchEvent(
fetch_dispatcher_.reset();
ServiceWorkerMetrics::RecordFetchEventStatus(IsMainResourceLoad(), status);
- // Check if we're not orphaned.
- if (!request()) {
- RecordResult(ServiceWorkerMetrics::REQUEST_JOB_ERROR_NO_REQUEST);
- return;
- }
-
ServiceWorkerMetrics::URLRequestJobResult result =
ServiceWorkerMetrics::REQUEST_JOB_ERROR_BAD_DELEGATE;
if (!delegate_->RequestStillValid(&result)) {
@@ -776,8 +768,9 @@ bool ServiceWorkerURLRequestJob::IsFallbackToRendererNeeded() const {
fetch_type_ != ServiceWorkerFetchType::FOREIGN_FETCH &&
(request_mode_ == FETCH_REQUEST_MODE_CORS ||
request_mode_ == FETCH_REQUEST_MODE_CORS_WITH_FORCED_PREFLIGHT) &&
- !request()->initiator().IsSameOriginWith(
- url::Origin(request()->url()));
+ (!request()->initiator().has_value() ||
+ !request()->initiator()->IsSameOriginWith(
+ url::Origin(request()->url())));
}
void ServiceWorkerURLRequestJob::SetResponseBodyType(ResponseBodyType type) {

Powered by Google App Engine
This is Rietveld 408576698