Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3574)

Unified Diff: build/android/pylib/local/device/local_device_gtest_run.py

Issue 2480203002: ui: Cleanup class/struct forward declarations (Closed)
Patch Set: Sync CL to position 430550 Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/pylib/local/device/local_device_gtest_run.py
diff --git a/build/android/pylib/local/device/local_device_gtest_run.py b/build/android/pylib/local/device/local_device_gtest_run.py
index b4d3daafd94ae38c3e637d2913720c405330aaf6..6796734c7d6a38f24651011b7ed7ca5b2d22378a 100644
--- a/build/android/pylib/local/device/local_device_gtest_run.py
+++ b/build/android/pylib/local/device/local_device_gtest_run.py
@@ -106,6 +106,11 @@ class _ApkDelegate(object):
self._component = '%s/%s' % (self._package, self._runner)
self._extras = test_instance.extras
+ def GetTestDataRoot(self, device):
+ # pylint: disable=no-self-use
+ return posixpath.join(device.GetExternalStoragePath(),
+ 'chromium_tests_root')
+
def Install(self, device):
if self._test_apk_incremental_install_script:
local_device_test_run.IncrementalInstall(device, self._apk_helper,
@@ -170,6 +175,11 @@ class _ExeDelegate(object):
constants.TEST_EXECUTABLE_DIR, os.path.basename(dist_dir))
self._test_run = tr
+ def GetTestDataRoot(self, device):
+ # pylint: disable=no-self-use
+ # pylint: disable=unused-argument
+ return posixpath.join(constants.TEST_EXECUTABLE_DIR, 'chromium_tests_root')
+
def Install(self, device):
# TODO(jbudorick): Look into merging this with normal data deps pushing if
# executables become supported on nonlocal environments.
@@ -247,8 +257,7 @@ class LocalDeviceGtestRun(local_device_test_run.LocalDeviceTestRun):
def push_test_data():
# Push data dependencies.
- device_root = posixpath.join(dev.GetExternalStoragePath(),
- 'chromium_tests_root')
+ device_root = self._delegate.GetTestDataRoot(dev)
data_deps = self._test_instance.GetDataDependencies()
host_device_tuples = [
(h, d if d is not None else device_root)

Powered by Google App Engine
This is Rietveld 408576698