Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5655)

Unified Diff: chrome/browser/net/net_error_tab_helper_unittest.cc

Issue 2480203002: ui: Cleanup class/struct forward declarations (Closed)
Patch Set: Sync CL to position 430550 Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/net/net_error_tab_helper_unittest.cc
diff --git a/chrome/browser/net/net_error_tab_helper_unittest.cc b/chrome/browser/net/net_error_tab_helper_unittest.cc
index 4a7facc47324bca3174798e20900b800f30c68df..5dcf9f168dfc044df314eaa33dd632056db8f8d3 100644
--- a/chrome/browser/net/net_error_tab_helper_unittest.cc
+++ b/chrome/browser/net/net_error_tab_helper_unittest.cc
@@ -365,7 +365,7 @@ TEST_F(NetErrorTabHelperTest, NoDiagnosticsForNonHttpSchemes) {
TEST_F(NetErrorTabHelperTest, DownloadPageLater) {
GURL url("http://somewhere:123/");
LoadURL(url, false /*succeeded*/);
- tab_helper()->DownloadPageLater(url);
+ tab_helper()->DownloadPageLater();
EXPECT_EQ(url, tab_helper()->download_page_later_url());
EXPECT_EQ(1, tab_helper()->times_download_page_later_invoked());
}
@@ -373,23 +373,14 @@ TEST_F(NetErrorTabHelperTest, DownloadPageLater) {
TEST_F(NetErrorTabHelperTest, NoDownloadPageLaterOnNonErrorPage) {
GURL url("http://somewhere:123/");
LoadURL(url, true /*succeeded*/);
- tab_helper()->DownloadPageLater(url);
+ tab_helper()->DownloadPageLater();
EXPECT_EQ(0, tab_helper()->times_download_page_later_invoked());
}
-TEST_F(NetErrorTabHelperTest, NoDownloadPageLaterOnUrlMismatch) {
- GURL url("http://somewhere:123/");
- LoadURL(url, false /*succeeded*/);
- tab_helper()->DownloadPageLater(GURL("http://other/"));
- EXPECT_EQ(0, tab_helper()->times_download_page_later_invoked());
-}
-
-// Makes sure that "Download page later" isn't run on invalid URLs or URLs
-// with non-HTTP/HTTPS schemes.
+// Makes sure that "Download page later" isn't run on URLs with non-HTTP/HTTPS
+// schemes.
TEST_F(NetErrorTabHelperTest, NoDownloadPageLaterForNonHttpSchemes) {
const char* kUrls[] = {
- "",
- "http",
"file:///blah/blah",
"chrome://blah/",
"about:blank",
@@ -398,7 +389,7 @@ TEST_F(NetErrorTabHelperTest, NoDownloadPageLaterForNonHttpSchemes) {
for (const char* url_string : kUrls) {
GURL url(url_string);
LoadURL(url, false /*succeeded*/);
- tab_helper()->DownloadPageLater(url);
+ tab_helper()->DownloadPageLater();
EXPECT_EQ(0, tab_helper()->times_download_page_later_invoked());
}
}
« no previous file with comments | « chrome/browser/net/net_error_tab_helper.cc ('k') | chrome/browser/notifications/notification_platform_bridge_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698